[Cbe-oss-dev] [patch/rfc 2/2] spufs: remove dead code

Christoph Hellwig hch at lst.de
Sat Aug 11 13:55:19 EST 2007


On Fri, Aug 10, 2007 at 04:45:37PM +1000, Jeremy Kerr wrote:
> Sebastian,
> 
> > This code seems to be not used anymore. Compiled with SPUFS=m as well
> > =y with no trouble.
> 
> NACK - we need sys_spu_create for, you know, creating SPUs :)
> 
> (it's used for CONFIG_SPU_FS=y)
> 
> However, do we really need to avoid the indirect branch when spufs is 
> compiled into the kernel? Perhaps we should always compile 
> spu_syscalls.c in, and avoid duplicating the sys_spu_create wrapper.

I would much prefer having unified code for the modular/non-modular
cases.



More information about the cbe-oss-dev mailing list