[Cbe-oss-dev] [PATCH] fix recursive spu_acquire() in SPU pagefault handling

[Akinobu Mita]

On Thu, Apr 19, 2007 at 11:30:51AM +0200, Arnd Bergmann wrote:
> On Thursday 19 April 2007, Akinobu Mita wrote:
> > This patch resolves the problem by releasing spu_context while 
> > calling spu_irq_class_1_bottom(). because it may acquire spu_context again.
> > 
> > Signed-off-by: Akinobu Mita <mita at fixstars.com>
> 
> No, this is broken, because spu_irq_class_1_bottom accesses registers of the
> spu itself, and once you give up the spu context mutex with spu_release,
> it may gets scheduled away at any time.
> 
> I fixed this bug some time ago, the patch is in my tree as
> http://www.kernel.org/pub/linux/kernel/people/arnd/patches/2.6.21-rc4-arnd1/broken-out/spufs-pagefault-rework.diff
> 

OK, this patch fixes the problem here. Thank you.