[Cbe-oss-dev] [PATCH 11/16] sysfs: add support for adding/removing spu sysfs attributes

Heiko Carstens heiko.carstens at de.ibm.com
Wed Oct 25 17:52:38 EST 2006


> +int cpu_add_sysdev_attr(struct sysdev_attribute *attr)
> +{
> +	int cpu;
> +
> +	mutex_lock(&cpu_mutex);
> +
> +	for_each_possible_cpu(cpu) {
> +		sysdev_create_file(get_cpu_sysdev(cpu), attr);
> +	}
> +
> +	mutex_unlock(&cpu_mutex);
> +	return 0;
> +}

You probably should check for errors on sysdev_create_file, clean up and
return an error number instead of always 0.
This is true for all the new functions here.



More information about the cbe-oss-dev mailing list