[Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write	oncntl
    Noguchi, Masato 
    Masato.Noguchi at jp.sony.com
       
    Tue Oct 10 16:00:14 EST 2006
    
    
  
After applying these patches, it seems the kernel leaks memory.
No doubt you forget to call simple_attr_close on "[PATCH 09/14]
spufs: add support for read/write oncntl".
Signed-off-by: Masato Noguchi <Masato.Noguchi at jp.sony.com>
---
Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode 
 
 static struct file_operations spufs_cntl_fops = {
 	.open = spufs_cntl_open,
+	.close = simple_attr_close,
 	.read = simple_attr_read,
 	.write = simple_attr_write,
 	.mmap = spufs_cntl_mmap,
    
    
More information about the cbe-oss-dev
mailing list