[Cbe-oss-dev] [PATCH] spufs: fix missing stop-and-signal

Arnd Bergmann arnd at arndb.de
Fri Nov 17 03:27:03 EST 2006


On Thursday 16 November 2006 06:51, Masato Noguchi wrote:
> This patch fixes missing stop-and-signal problem.
> 
> When there is pending signals, current spufs_run_spu() always returns 
> -ERESTERTSYS and it is called again automatically.
> But, if spe already stopped by stop-and-signal or halt instruction,
> returning -ERESTARTSYS makes stop-and-signal/halt lost and 
> spu run over the end-point.
> 
> For your convenience, I attached a sample code to restage this bug.
> If there is no bug, printed NPC will be 0x4000.
> 
> Signed-off-by: Masato Noguchi <Masato.Noguchi at jp.sony.com>

Ok, thanks for hunting this down. I'll forward it for
inclusion soon. Do you see this in real-life programs, so
that we should fix it in 2.6.19? If not, I'll queue the fix
up together with the other 2.6.20 patches that I want to
still submit.

	Arnd <><



More information about the cbe-oss-dev mailing list