[Cbe-oss-dev] [PATCH] libspe2: fix definitions of public constants

Kazunori Asayama asayama at sm.sony.co.jp
Thu Nov 16 12:57:35 EST 2006


Attached is a patch to fix the bug in libspe2 below:

	- Some public constants are defined in the private header.

--
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t
-------------- next part --------------
Index: libspe2/libspe2-types.h
===================================================================
--- libspe2.orig/libspe2-types.h
+++ libspe2/libspe2-types.h
@@ -181,8 +181,8 @@ enum ps_area { SPE_MSSYNC_AREA, SPE_MFC_
 /**
  * Flags for spe_gang_context_create
  */
-
-/* none defined today */
+#define SPE_GANG_CONCURRENCY	  0x00000100
+#define SPE_GANG_AFFINITY	      0x00000200
 
 /**
  * Symbolic constants for stop reasons
@@ -196,6 +196,11 @@ enum ps_area { SPE_MSSYNC_AREA, SPE_MFC_
 #define SPE_CALLBACK_ERROR		6
 
 /**
+ * SIGSPE maps to SIGURG 
+ */
+#define SIGSPE SIGURG
+
+/**
  * Supported SPE events
  */
 #define SPE_EVENT_OUT_INTR_MBOX		0x00000001
@@ -227,6 +232,12 @@ enum ps_area { SPE_MSSYNC_AREA, SPE_MFC_
 #define SPE_NO_CALLBACKS	0x00000002
 
 
+/**
+ * Signal Targets 
+ */
+#define SPE_SIG_NOTIFY_REG_1		0x0001
+#define SPE_SIG_NOTIFY_REG_2		0x0002
+
 #ifdef __cplusplus
 }
 #endif
Index: libspe2/spebase/spebase.h
===================================================================
--- libspe2.orig/spebase/spebase.h
+++ libspe2/spebase/spebase.h
@@ -82,12 +82,6 @@ struct spe_context_base_priv {
 };
 
 
-#define SPE_CFG_SIGNOTIFY1_OR     0x00000010
-#define SPE_CFG_SIGNOTIFY2_OR     0x00000020
-#define SPE_MAP_PS				  0x00000040
-#define SPE_GANG_CONCURRENCY	  0x00000100
-#define SPE_GANG_AFFINITY	      0x00000200
-
 /* spe related sizes
  */
 
@@ -121,18 +115,6 @@ struct spe_gang_context_base_priv
 };
 
 
-/* SIGSPE maps to SIGURG 
-*/
-
-#define SIGSPE SIGURG
-
-//
-/* Signal Targets 
- */
-
-#define SPE_SIG_NOTIFY_REG_1		0x0001
-#define SPE_SIG_NOTIFY_REG_2		0x0002
-
 /* Function Prototypes
  */
 


More information about the cbe-oss-dev mailing list