[Cbe-oss-dev] spufs: fix hotplug
Geoff Levand
geoffrey.levand at am.sony.com
Tue Jun 13 08:53:14 EST 2006
This is a partial/cosmetic fix. What is also needed is a way to select
SPARSEMEM when SPU_FS is selected, but I couldn't find the way
to do that from arch/powerpc/platforms/cell/Kconfig.
I came across this trouble when selecting cell support with g5_defconfig,
which has FLATMEM_MANUAL=y. Currently the user needs to select cell
support and SPARSEMEM_MANUAL=y, otherwise, a build error will result.
-Geoff
spufs_base.c calls __add_pages, which depends on CONFIG_MEMORY_HOTPLUG.
Moved the selection of CONFIG_MEMORY_HOTPLUG from CONFIG_SPUFS_MMAP
to CONFIG_SPU_FS.
Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
Index: cell--common--1/arch/powerpc/platforms/cell/Kconfig
===================================================================
--- cell--common--1.orig/arch/powerpc/platforms/cell/Kconfig 2006-06-12 15:07:19.000000000 -0700
+++ cell--common--1/arch/powerpc/platforms/cell/Kconfig 2006-06-12 15:25:58.000000000 -0700
@@ -16,6 +16,7 @@
default m
depends on PPC_CELL
select SPU_BASE
+ select MEMORY_HOTPLUG
help
The SPU file system is used to access Synergistic Processing
Units on machines implementing the Broadband Processor
@@ -28,7 +29,6 @@
config SPUFS_MMAP
bool
depends on SPU_FS && SPARSEMEM
- select MEMORY_HOTPLUG
default y
endmenu
More information about the cbe-oss-dev
mailing list