[Cbe-oss-dev] Subject: cbe_thermal: fix initialization of sysfs attribute_group

Paul Mackerras paulus at samba.org
Fri Dec 8 15:34:12 EST 2006


Christian Krafft writes:

> This patch adds NULL to the initialization of the attribute_groups.
> 
> Signed-off-by: Christian Krafft <krafft at de.ibm.com>
> 
> Index: linux-2.6.19-rc6/arch/powerpc/platforms/cell/cbe_thermal.c
> ===================================================================
> --- linux-2.6.19-rc6.orig/arch/powerpc/platforms/cell/cbe_thermal.c
> +++ linux-2.6.19-rc6/arch/powerpc/platforms/cell/cbe_thermal.c
> @@ -115,6 +115,7 @@ static struct sysdev_attribute attr_spu_
>  
>  static struct attribute *spu_attributes[] = {
>  	&attr_spu_temperature.attr,
> +	NULL,

This is unnecessary - the compiler has to set uninitialized pointer
fields to NULL anyway.

Paul.



More information about the cbe-oss-dev mailing list