[Cbe-oss-dev] [patch 3/6] spufs: support multi-platform priv1 access

[Geoff Levand]

Christoph Hellwig wrote:
>> - * access to SPU privileged registers
>> + * spu_priv1.c - This file implements the spu hypervisor abstractions
>> + * for running on raw hardware in hypervisor state.
> 
> this sentence doesn't make any sense.  it's just direct hardware access,
> no need to mention the buzzword of the day two times.  also never
> mention the file name in such comments, it's redundant information that
> gets out of sync easily.


Good point.


>> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + *  GNU General Public License for more details.
>> + *
>> + *  You should have received a copy of the GNU General Public License
>> + *  along with this program; if not, write to the Free Software
>> + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>>   */
> 
> just scrap this.  The COPYING file in the toplevel dir implies all this. 


Sorry, my legal dept. makes me put that in any new file I create...


-Geoff