[Cbe-oss-dev] [patch 4/6] spufs: wrap cpu affinity

Geoff Levand geoffrey.levand at am.sony.com
Fri Apr 28 02:20:17 EST 2006


Arnd Bergmann wrote:
> On Wednesday 26 April 2006 23:52, Geoff Levand wrote:
>>  void spu_irq_setaffinity(struct spu *spu, int cpu)
>>  {
>> -       u64 target = iic_get_target_id(cpu);
>> -       u64 route = target << 48 | target << 32 | target << 16;
>> -       spu_int_route_set(spu, route);
>> +       spu_set_cpu_affinity(spu, cpu);
>>  }
>>  EXPORT_SYMBOL_GPL(spu_irq_setaffinity);
>> 
> 
> That makes this function completely obsolete, because it
> only calls another function. Just convert the caller to
> use spu_set_cpu_affinity directly.

I was thinking of that, but I did it this way to keep the
priv1 ops contained within the base.  I suppose it doesn't
matter, and your suggestion will simplify the code.

-Geoff




More information about the cbe-oss-dev mailing list