[Cbe-oss-dev] [patch 2/6] cell: split out platform code

[Christoph Hellwig]

> +config SPU_FS_RAWIO
> +	bool
> +	default n

this is named very badly. 

> +#ifdef PPC_IBM_CELL_BLADE
>  	&cell_md,
>  #endif

please give cell_md a better name, e.g. cpbw_md.

> +ifdef CONFIG_PPC_IBM_CELL_BLADE
>  obj-y			+= interrupt.o iommu.o setup.o spider-pic.o
>  obj-y			+= pervasive.o pci.o
> -
>  obj-$(CONFIG_SMP)	+= smp.o
> +endif
> +

please make this:

obj-$(CONFIG_PPC_IBM_CELL_BLADE)	+= interrupt.o iommu.o setup.o \
					   spider-pic.o pervasive.o pci.o
ifeq($(CONFIG_SMP),y)
obj-$(CONFIG_PPC_IBM_CELL_BLADE)	+= smp.o
endif

note that some of these files should be renamed.  All files in
arch/powerpc/platforms/cell should be grouped into a few categories:

 - generic cell stuff, no prefix
 - bits specific to boards using the bare first generic spider based
   hardware as in the ibm blade, and the ps3 once people reverse
   engineered the sony digital restriction managment crap, which will be
   soon after the hardware is released.
 - axon bits
 - $chipset bits
 - bits needed to talk to the hypervisor