[Cbe-oss-dev] [patch 3/6] spufs: support multi-platform priv1 access

[Stephen Rothwell]

Hi Geoff,

Just a couple of nits ...

On Wed, 26 Apr 2006 14:52:39 -0700 Geoff Levand <geoffrey.levand at am.sony.com> wrote:
>
> @@ -60,6 +61,7 @@
>  #define DBG(fmt...)
>  #endif
>  extern void cell_final_fixup(void);
> +extern const struct spu_priv1_ops spu_raw_priv1_ops;

You should declare this in an appropriate header file.

> Index: cell--alp--1/include/asm-powerpc/spu_priv1.h
> ===================================================================
> +
> +extern const struct spu_priv1_ops* spu_priv1_ops;
                                    ^^
Space before the * (not after).

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20060427/e88aa4dc/attachment.pgp>