<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<br>
<br>
<div class="moz-cite-prefix">Le 21/06/2023 à 06:34, Nicholas Piggin
a écrit :<br>
</div>
<blockquote type="cite" cite="mid:CTI1R5JOREVK.2ZIB4O8HAGQDN@wheely">
<pre class="moz-quote-pre" wrap="">On Wed Jun 21, 2023 at 12:52 AM AEST, Christophe Lombard wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">To retrieve specific log traces from the external library: libmctp, we
need to export the logging api.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Seems okay. Should it be prefixed with single underscore because it
does not have pr_fmt applied? Otherwise,
</pre>
</blockquote>
<br>
<span _ngcontent-serverapp-c68="" class="text__translation">that
would make sense.<br>
<br>
</span>
<blockquote type="cite" cite="mid:CTI1R5JOREVK.2ZIB4O8HAGQDN@wheely">
<pre class="moz-quote-pre" wrap="">
Reviewed-by: Nicholas Piggin <a class="moz-txt-link-rfc2396E" href="mailto:npiggin@gmail.com"><npiggin@gmail.com></a>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Christophe Lombard <a class="moz-txt-link-rfc2396E" href="mailto:clombard@linux.ibm.com"><clombard@linux.ibm.com></a>
---
core/console-log.c | 2 +-
include/skiboot.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/core/console-log.c b/core/console-log.c
index 21a1442b..a0d11768 100644
--- a/core/console-log.c
+++ b/core/console-log.c
@@ -15,7 +15,7 @@
#include "timebase.h"
#include <debug_descriptor.h>
-static int vprlog(int log_level, const char *fmt, va_list ap)
+int vprlog(int log_level, const char *fmt, va_list ap)
{
int count;
char buffer[320];
diff --git a/include/skiboot.h b/include/skiboot.h
index b0b75a42..88857f8f 100644
--- a/include/skiboot.h
+++ b/include/skiboot.h
@@ -79,6 +79,7 @@ static inline bool is_rodata(const void *p)
#define pr_fmt(fmt) fmt
#endif
+int vprlog(int log_level, const char *fmt, va_list ap);
void _prlog(int log_level, const char* fmt, ...) __attribute__((format (printf, 2, 3)));
#define prlog(l, f, ...) do { _prlog(l, pr_fmt(f), ##__VA_ARGS__); } while(0)
#define prerror(fmt...) do { prlog(PR_ERR, fmt); } while(0)
--
2.40.1
_______________________________________________
Skiboot mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Skiboot@lists.ozlabs.org">Skiboot@lists.ozlabs.org</a>
<a class="moz-txt-link-freetext" href="https://lists.ozlabs.org/listinfo/skiboot">https://lists.ozlabs.org/listinfo/skiboot</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
<br>
</body>
</html>