<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<br>
<div class="moz-cite-prefix">Le 21/06/2023 à 07:01, Nicholas Piggin
a écrit :<br>
</div>
<blockquote type="cite" cite="mid:CTI2BTF7W327.51UTYBK53IT9@wheely">
<pre class="moz-quote-pre" wrap="">On Wed Jun 21, 2023 at 12:59 AM AEST, Christophe Lombard wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Add new lpc helpers for doing a bulk io to firmware space.
Reviewed-by: Abhishek Singh Tomar <a class="moz-txt-link-rfc2396E" href="mailto:abhishek@linux.ibm.com"><abhishek@linux.ibm.com></a>
Signed-off-by: Christophe Lombard <a class="moz-txt-link-rfc2396E" href="mailto:clombard@linux.ibm.com"><clombard@linux.ibm.com></a>
---
hw/lpc.c | 74 ++++++++++++++++++++++++++++++++
include/lpc.h | 6 +++
libflash/ipmi-hiomap.c | 66 +---------------------------
libflash/mbox-flash.c | 64 +--------------------------
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Good cleanup. How close are you to also getting
hw/ast-bmc/ast-sf-ctrl.c?
</pre>
</blockquote>
<br>
Good catch ! <span class="HwtZe" lang="en"><span class="jCAhz
ChMk0b"><span class="ryNqvb">we could actually also clean up
this file.<br>
<br>
</span></span></span>
<blockquote type="cite" cite="mid:CTI2BTF7W327.51UTYBK53IT9@wheely">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">diff --git a/libflash/test/mbox-server.c b/libflash/test/mbox-server.c
index 8a68cfff..053be989 100644
--- a/libflash/test/mbox-server.c
+++ b/libflash/test/mbox-server.c
@@ -142,6 +142,74 @@ int64_t lpc_write(enum OpalLPCAddressType __unused addr_type, uint32_t addr,
return 0;
}
+int64_t lpc_fw_read(uint32_t off, void *buf, uint32_t len);
+int64_t lpc_fw_read(uint32_t off, void *buf, uint32_t len)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Could you just make these really simple? I thind read should
just memset(buf, 0xaa, len); and write should just do nothing
(or maybe assert(len != 0);</pre>
</blockquote>
<br>
Absolutely, we could do that. Thanks<br>
<br>
<blockquote type="cite" cite="mid:CTI2BTF7W327.51UTYBK53IT9@wheely">
<pre class="moz-quote-pre" wrap="">
Thanks,
Nick
</pre>
</blockquote>
<br>
</body>
</html>