<html><body><p><tt><font size="2">"Vasant Hegde" <hegdevasant@linux.vnet.ibm.com> wrote on 10/11/2019 05:16:46 AM:<br><br>> From: "Vasant Hegde" <hegdevasant@linux.vnet.ibm.com></font></tt><br><tt><font size="2">> To: "Oliver O'Halloran" <oohall@gmail.com>, skiboot@lists.ozlabs.org</font></tt><br><tt><font size="2">> Cc: Carol L Soto/Poughkeepsie/IBM@IBMUS</font></tt><br><tt><font size="2">> Date: 10/11/2019 05:16 AM</font></tt><br><tt><font size="2">> Subject: Re: [Skiboot] [PATCH 2/2] core/init: Checksum romem after <br>> patching out traps</font></tt><br><tt><font size="2">> <br>> On 10/11/19 9:57 AM, Oliver O'Halloran wrote:<br>> > Currently we checksum the read-only parts of skiboot's memory just<br>> > before loading and booting petitboot. Commit 9ddc1a6bfaef<br>> > ("core/util: trap based assertions") modifies the .text after this<br>> > point since it needs to disable the trap instructions that we use<br>> > to trigger an abort() before entering the kernel.<br>> > <br>> > We can fix this by moving the checksum to after the point where the<br>> > traps are patched out. We could do the patching sooner, but since<br>> > load_and_boot_kernel() is a fairly complex function it's perferable<br>> > to keep boot-time assertion infrastructure active until just before<br>> > we enter the kernel.<br>> > <br>> > Reported-by: Carol L Soto <clsoto@us.ibm.com><br>> > Fixes: 9ddc1a6bfaef ("core/util: trap based assertions")<br>> > Signed-off-by: Oliver O'Halloran <oohall@gmail.com><br>> <br>> Looks good to me and it fixed fast-reboot issue.<br>> <br>> Tested-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com><br>> <br>> <br>> -Vasant<br></font></tt><br><tt><font size="2">It fixed the issue. thanks</font></tt><br><tt><font size="2">Tested-by: Carol L Soto <clsoto@us.ibm.com></font></tt><br><br><BR>
</body></html>