<font size=2 face="sans-serif">Seems right to me</font><br><font size=2 face="sans-serif"><br>--<br>Dan Crowell<br>Senior Software Engineer - Power Systems Enablement Firmware<br>IBM Rochester: t/l 553-2987<br>dcrowell@us.ibm.com</font><br><br><br><br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Vasant Hegde <hegdevasant@linux.vnet.ibm.com></font><br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">skiboot@lists.ozlabs.org</font><br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
Jeremy Kerr <jk@ozlabs.org>, Daniel M Crowell/Rochester/IBM@IBMUS</font><br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">09/21/2017 09:20 AM</font><br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[PATCH 2/2]
opal-prd: Fix opal-prd command line options</font><br><hr noshade><br><br><br><tt><font size=2>HBRT OCC reset interface depends on service processor
type.<br> FSP -> reset_pm_complex()<br> BMC -> process_occ_reset()<br><br>We have both `occ` and `pm-complex` command line interfaces.<br>This patch adds support to dispaly appropriate message depending<br>on system type.<br> FSP -> opal-prd occ --> display
error message<br> FSP -> opal-prd pm-complex --> Call pm_complex_reset()<br> BMC -> opal-prd occ --> Call process_occ_reset()<br> BMC -> opal-prd pm-complex --> display error message<br><br>CC: Jeremy Kerr <jk@ozlabs.org><br>CC: Daniel M Crowell <dcrowell@us.ibm.com><br>Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com><br>---<br> external/opal-prd/opal-prd.c | 19 +++++++++++++++++--<br> 1 file changed, 17 insertions(+), 2 deletions(-)<br><br>diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c<br>index 20ce5da..c26cc95 100644<br>--- a/external/opal-prd/opal-prd.c<br>+++ b/external/opal-prd/opal-prd.c<br>@@ -1584,7 +1584,7 @@ static void handle_prd_control_occ_reset(struct control_msg
*send_msg,<br> chip
= msg->occ_reset.chip;<br> <br> /*
do reset */<br>-
pr_debug("CTRL: resetting PM complex on chip %ld", chip);<br>+
pr_debug("CTRL: Calling OCC reset on chip %ld", chip);<br> pm_complex_reset(chip);<br> <br> send_msg->data_len
= 0;<br>@@ -2326,9 +2326,24 @@ static int parse_action(const char *str, enum action
*action)<br> {<br> int
rc;<br> <br>-
if (!strcmp(str, "occ") || !strcmp(str, "pm-complex"))
{<br>+
if (!strcmp(str, "occ")) {<br>
*action = ACTION_OCC_CONTROL;<br>
rc = 0;<br>+<br>+
if
(is_fsp_system()) {<br>+
pr_log(LOG_ERR, "CTRL: occ commands are not "<br>+
"supported on this system");<br>+
rc = -1;<br>+
}<br>+
} else if (!strcmp(str, "pm-complex")) {<br>+
*action
= ACTION_OCC_CONTROL;<br>+
rc
= 0;<br>+<br>+
if
(!is_fsp_system()) {<br>+
pr_log(LOG_ERR, "CTRL: pm-complex commands are not "<br>+
"supported on this system");<br>+
rc = -1;<br>+
}<br> }
else if (!strcmp(str, "daemon")) {<br>
*action = ACTION_RUN_DAEMON;<br>
rc = 0;<br>-- <br>2.9.3<br><br></font></tt><br><br><BR>