<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 08/25/2015 09:24 AM, Patrick
Williams wrote:<br>
</div>
<blockquote cite="mid:20150825035418.GV30624@asimov.austin.ibm.com"
type="cite">
<pre wrap="">On Mon, Aug 24, 2015 at 10:39:40PM -0500, Daniel M Crowell wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I don't like mfg_ as a prefix for this one because it likely would have
nothing to do with manufacturing. I would suggest some kind of --debug
flag but that is already in use. Maybe "opdev_" for Open Power Developer?
</pre>
</blockquote>
<pre wrap="">
Maybe we should have made it --expert-mode instead of --mfg-mode?
The htmgt interface was prefixed with 'mfg' so that gives an obvious linkage
to which functions should be triggered by this extra option.</pre>
</blockquote>
<br>
<small>So, the idea of '--expert-mode' is to cover up both
interfaces 'htmgt_passthru' and<br>
'run_command' ? And we can keep the interface names as
'mfg_htmgt_pass_thru'<br>
and 'run_command' respectively..<br>
<br>
Neelesh.<br>
</small><br>
<blockquote cite="mid:20150825035418.GV30624@asimov.austin.ibm.com"
type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
--
Dan Crowell
Senior Software Engineer - Power Systems Enablement Firmware
IBM Rochester: t/l 553-2987
<a class="moz-txt-link-abbreviated" href="mailto:dcrowell@us.ibm.com">dcrowell@us.ibm.com</a>
From: Patrick Williams <a class="moz-txt-link-rfc2396E" href="mailto:patrick@stwcx.xyz"><patrick@stwcx.xyz></a>
To: Neelesh Gupta <a class="moz-txt-link-rfc2396E" href="mailto:neelegup@linux.vnet.ibm.com"><neelegup@linux.vnet.ibm.com></a>
Cc: <a class="moz-txt-link-abbreviated" href="mailto:skiboot@lists.ozlabs.org">skiboot@lists.ozlabs.org</a>, Daniel M Crowell/Rochester/IBM@IBMUS,
Bill Schwartz/Austin/IBM@IBMUS, Christopher J Cain/Rochester/IBM@IBMUS
Date: 08/24/2015 05:02 PM
Subject: Re: [Skiboot] [PATCH v2 5/5] external/opal-prd: Add 'run'
option to execute HBRT commands
On Tue, Aug 25, 2015 at 12:50:37AM +0530, Neelesh Gupta wrote:
</pre>
<blockquote type="cite">
<pre wrap="">From: Vaidyanathan Srinivasan <a class="moz-txt-link-rfc2396E" href="mailto:svaidy@linux.vnet.ibm.com"><svaidy@linux.vnet.ibm.com></a>
opal-prd client to accept run command and pass it as-is to hbrt.
Example:
opal-prd -d run test hbrt -t 1 -c "good cmd"
argv[0] = test
argv[1] = hbrt
argv[2] = -t
argv[3] = 1
argv[4] = -c
argv[5] = good cmd
Above argc/argv passed to hbrt->run_command() and result out string
sent to the console.
</pre>
</blockquote>
<pre wrap="">
Is this one suppose to be a 'manufacturing' command as well? I don't
believe our intention is to use this for any permanent code. This
should be one of those "only use if you know what you are doing"
commands.
We may want to change the name of the Hostboot side to 'mfg_run_command'
if we determine this is a 'manufacturing' command.
~~
Patrick Williams
[attachment "signature.asc" deleted by Daniel M Crowell/Rochester/IBM]
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>