<html><body><p>Recommend adding 'Fixes open-power/skiboot#19' to commit message for github. <br><br>Otherwise,<br><br>Reviewed-by: Patrick Williams <iawillia@us.ibm.com><br><br>Sent from my iPhone<br><br>> On Aug 5, 2015, at 2:49 AM, Samuel Mendoza-Jonas <sam.mj@au1.ibm.com> wrote:<br>> <br>> Some warnings may not be supported in older host compilers - remove them<br>> from HOSTCFLAGS but keep them for CFLAGS<br>> <br>> Removed from HOSTCFLAGS:<br>> -Wjump-misses-init<br>> -Wsuggest-attribute=const<br>> -Wsuggest-attribute=noreturn<br>> -Wstack-usage=1024<br>> <br>> Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com><br>> ---<br>> Makefile.main | 12 +++++++++++-<br>> 1 file changed, 11 insertions(+), 1 deletion(-)<br>> <br>> diff --git a/Makefile.main b/Makefile.main<br>> index 48d8b8d..2d929b6 100644<br>> --- a/Makefile.main<br>> +++ b/Makefile.main<br>> @@ -26,10 +26,20 @@ CWARNS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \<br>> -Wframe-larger-than=1024 -Wstack-usage=1024 \<br>> -Werror -Wno-error=format<br>> <br>> +# Host base warnings<br>> +HOSTCWARNS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \<br>> + -Werror-implicit-function-declaration -Wdeclaration-after-statement \<br>> + -Wno-pointer-sign -Wextra -Wno-sign-compare \<br>> + -Wmissing-prototypes -Wmissing-declarations \<br>> + -Wwrite-strings -Wcast-align \<br>> + -Winit-self \<br>> + -Wframe-larger-than=1024 \<br>> + -Werror -Wno-error=format<br>> +<br>> # Host tools and options<br>> HOSTCC=gcc<br>> HOSTEND=$(shell uname -m | sed -e 's/^i.*86$$/LITTLE/' -e 's/^x86.*/LITTLE/' -e 's/^ppc64le/LITTLE/' -e 's/^ppc.*/BIG/')<br>> -HOSTCFLAGS=-O1 $(CWARNS) -DHAVE_$(HOSTEND)_ENDIAN -MMD<br>> +HOSTCFLAGS=-O1 $(HOSTCWARNS) -DHAVE_$(HOSTEND)_ENDIAN -MMD<br>> VALGRIND=valgrind -q --show-reachable=yes --error-exitcode=99<br>> <br>> # Target options<br>> -- <br>> 2.5.0<br>> <br>> _______________________________________________<br>> Skiboot mailing list<br>> Skiboot@lists.ozlabs.org<br>> <a href="https://lists.ozlabs.org/listinfo/skiboot">https://lists.ozlabs.org/listinfo/skiboot</a><br><BR>
</body></html>