[Skiboot] [PATCH] core/init: Move opal_mpipl_init earlier

Nicholas Piggin npiggin at gmail.com
Sat May 13 22:33:14 AEST 2023


There doesn't seem to be any reason to call opal_mpipl_init so late,
after sleep, traps, interrupts, machine checks, watchdog, etc., are
all disabled. Move it earlier.

Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 core/init.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/core/init.c b/core/init.c
index 005ecf31..e832a009 100644
--- a/core/init.c
+++ b/core/init.c
@@ -574,6 +574,8 @@ void __noreturn load_and_boot_kernel(bool is_reboot)
 		if (!occ_sensors_init())
 			dts_sensor_create_nodes(sensor_node);
 
+		opal_mpipl_init();
+
 	} else {
 		/* fdt will be rebuilt */
 		free(fdt);
@@ -638,10 +640,6 @@ void __noreturn load_and_boot_kernel(bool is_reboot)
 	patch_traps(false);
 	cpu_set_hile_mode(false); /* Clear HILE on all CPUs */
 
-	/* init MPIPL */
-	if (!is_reboot)
-		opal_mpipl_init();
-
 	checksum_romem();
 
 	debug_descriptor.state_flags |= OPAL_BOOT_COMPLETE;
-- 
2.40.1



More information about the Skiboot mailing list