[Skiboot] [PATCH] Makefile: Link final elf with --no-warn-rwx-segments

Reza Arbab arbab at linux.ibm.com
Thu Aug 10 07:38:11 AEST 2023


On Wed, Jul 19, 2023 at 02:37:58PM +0930, Joel Stanley wrote:
>No system loads skiboot as an ELF, so the segment information is not
>used.
>
>Avoids these warnings with binutils as of 2.39:
>
> powerpc64-linux-gnu-ld: warning: skiboot.tmp.elf has a LOAD segment with RWX permissions
> powerpc64-linux-gnu-ld: warning: skiboot.elf has a LOAD segment with RWX permissions
>
>Signed-off-by: Joel Stanley <joel at jms.id.au>
>---
> Makefile.main | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Makefile.main b/Makefile.main
>index bfa24f61342f..934d4c2aa133 100644
>--- a/Makefile.main
>+++ b/Makefile.main
>@@ -190,6 +190,7 @@ LDFLAGS += -Wl,--oformat,elf64-powerpc
> LDFLAGS_FINAL = -m elf64lppc --no-multi-toc -N --build-id=none --whole-archive
> LDFLAGS_FINAL += -static -nostdlib -pie -Ttext-segment=$(LD_TEXT) --oformat=elf64-powerpc
> LDFLAGS_FINAL += --orphan-handling=warn
>+LDFLAGS_FINAL += --no-warn-rwx-segments

Applied to master. I wrapped it like this, to not break on systems with 
older binutils:

   LDFLAGS_FINAL += $(call try-ldflag,$(LD),--no-warn-rwx-segments)

-- 
Reza Arbab


More information about the Skiboot mailing list