[Skiboot] [PATCH v8 02/24] FSP/MDST: Rename fsp-mdst-table.c -> fsp-sysdump.c

[Vasant Hegde]

On 06/28/2019 06:24 AM, Nicholas Piggin wrote:
> Vasant Hegde's on June 17, 2019 3:10 am:
>> OPAL is using MDST ntuple in SPIRAH to pass list of memory region (mostly OPAL
>> console and host dmesg) to be collected as part of SYSDUMP. OPAL calls attn
>> instruction in assert path. FSP detects attention and creates SYSDUMP.
> 
> This is a bit hard to parse, I don't think you need to explain it in
> detail for this particular patch though.

I wanted to explain what we have today and what new feature I'm going to introduce.
If you want I can drop above description.

> 
>> Soon we are going to support OPAL MIPL feature (aka Memory Preserving IPL).
>> Hence make below changes to reflect its usage:
>>    - fsp-mdst-table.c -> fsp-sysdump.c
>>    - fsp-mdst-table.h -> opal-dump.h (This will cater both SYSDUMP and MPIPL)
>>    - Rename structure name : dump_mdst_table -> mdst_table
> 
> Now we have MPIPL, SYSDUMP, DUMP, FADUMP, and MDST.
> 
> Are these all completely different such that this makes sense, or can
> we consolidate a bit?

Yes. All are different and makes sense.
   MDST / MDDT / MDRT = These are ntuple name inside HDAT
   MPIPL = FADUMP = Memory Preserving dump mechanism
   SYSDUMP = System dump provided by FSP
   FIPSDUMP = FSP dump (We just collect and save it in host Linux)
   DUMP = Infrastructure to offload SYSDUMP/FIPSDUMP

-Vasant