[Skiboot] [PATCH] fast-reboot: move pci_reset error handling into fast-reboot code

Stewart Smith stewart at linux.vnet.ibm.com
Fri Feb 9 16:07:37 AEDT 2018


Nicholas Piggin <npiggin at gmail.com> writes:
> pci_reset() currently does a platform reboot if it fails. It
> should not know about fast-reboot at this level, so instead have
> it return an error, and the fast reboot caller will do the
> platform reboot.
>
> The code essentially does the same thing, but flexibility is
> improved. Ideally the fast reboot code should perform pci_reset
> and all such fail-able operations before the CPU resets itself
> and destroys its own stack. That's not the case now, but that
> should be the goal.

I like it!

Merged to master as of d2cc3957abef48f3afdf8ec61d69e87e3446d562

HOpefully we can figure out the remaining weirdness that Vaidy mentioned
and fix it up.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list