[Skiboot] [PATCH 2/3] hdata: Add wafer-id property

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Sep 28 16:50:18 AEST 2017


On 09/28/2017 12:07 PM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> +
>> +	/*
>> +	 * bits 4:63 of ECID data contains wafter ID data (ten 6 bit fields
>> +	 * each containing a code).
>> +	 */
>> +	for (i = 0; i < 10; i++) {
>> +		tmp = (u8)((ecid->low >> (i * 6)) & 0x3f);
>
> This produces the following sparse warning:
>
> hdata/spira.c:433:33: warning: restricted beint64_t degrades to integer
>
> looks like we're missing some endian conversions?

My bad. . I missed be64_to_cpu() ... Will send separate patch for that.

-Vasant



More information about the Skiboot mailing list