[Skiboot] [PATCH] OCC: Increase max pstate check on P9 to 255

Stewart Smith stewart at linux.vnet.ibm.com
Fri Nov 17 09:34:03 AEDT 2017


This has changed from P8, we can now have > 127 pstates.

This was observed on Boston during WoF bringup.

Reported-by: Minda Wei <minda.wei at ibm.com>
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/occ.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/hw/occ.c b/hw/occ.c
index 78c6a6a356e3..8ad0dfe421d7 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -612,13 +612,15 @@ static bool add_cpu_pstate_properties(int *pstate_nom)
 	nr_pstates = labs(pmax - pmin) + 1;
 	prlog(PR_DEBUG, "OCC: Version %x Min %d Nom %d Max %d Nr States %d\n",
 	      occ_data->version, pmin, pnom, pmax, nr_pstates);
-	if (nr_pstates <= 1 || nr_pstates > 128) {
+	if ((occ_data->version == 0x90 && (nr_pstates <= 1)) ||
+	    (occ_data->version <= 0x02 &&
+	     (nr_pstates <= 1 || nr_pstates > 128))) {
 		/**
 		 * @fwts-label OCCInvalidPStateRange
 		 * @fwts-advice The number of pstates is outside the valid
-		 * range (currently <=1 or > 128), so OPAL has not added
-		 * pstates to the device tree. This means that OCC (On Chip
-		 * Controller) will be non-functional. This means
+		 * range (currently <=1 or > 128 on p8, >255 on P9), so OPAL
+		 * has not added pstates to the device tree. This means that
+		 * OCC (On Chip Controller) will be non-functional. This means
 		 * that CPU idle states and CPU frequency scaling
 		 * will not be functional.
 		 */
-- 
2.14.3



More information about the Skiboot mailing list