[Skiboot] [PATCH] PHB3: Disable UTL outbound discard error interrupt

Gavin Shan gwshan at linux.vnet.ibm.com
Wed Jun 22 13:17:58 AEST 2016


The UTL outbound discard error (bit#12) in UTL_PCIE_PORT_IRQ_EN
(offset: 0x558) isn't set in initial setup. It's set wrongly after
a reset on root port. With this bit set, frozen (all) error was
observed on the PHB to which a LPFC adapter is connected directly.

This removes the bit in reset handler to avoid the unexpected
frozen (all) error.

 BZ: 142877

Reported-by: Pridhiviraj Paidipeddi <ppaidipe at in.ibm.com>
Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
---
Good candidate for stable releases
---
 hw/phb3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/phb3.c b/hw/phb3.c
index 0b64532..905fdf4 100644
--- a/hw/phb3.c
+++ b/hw/phb3.c
@@ -1974,7 +1974,7 @@ static void phb3_prepare_link_change(struct pci_slot *slot,
 		out_be64(p->regs + UTL_PCIE_PORT_STATUS,
 			 0xffdfffffffffffff);
 		out_be64(p->regs + UTL_PCIE_PORT_IRQ_EN,
-			 0xad5a800000000000);
+			 0xad52800000000000);
 
 		/* Don't block PCI-CFG */
 		p->flags &= ~PHB3_CFG_BLOCKED;
-- 
2.1.0



More information about the Skiboot mailing list