[Skiboot] [RESEND PATCH 01/11]ibm-fsp/firenze: nest data structure definitions

[Madhavan Srinivasan]

On Thursday 16 July 2015 07:41 AM, Stewart Smith wrote:
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>> On Friday 10 July 2015 12:20 PM, Stewart Smith wrote:
>>> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>>>> Patch adds the data structures and macros needed for
>>>> Nest instrumentation support. Patch creates new file in
>>>> include dir called "nest.h".
>>> Are any parts of this ABI to kernel?
>>>
>>> It looks as though we have an ABI to PORE though, and I can't see
>>> anywhere where you check things like the magic number in these data
>>> structures.
>>>
>> Structures defined here are not ABI to kernel. Some of these
>> structures are related to catalog lid (meta-data file) parsing
>> and some of the structures are related to PORE SLW IMA
>> microcode.  Idea is to abstract the kernel from meta-data file
>> mess, so that kernel can have a generic interface.
> and that's a good thing.
>
> We should likely check the magic numbers and validity of the data
> structures though.

Yes. I will add the checks and spin off  a new version soon.

Also, I missing your review comments mail on patch 2 of this series,
I could see it in the mailing list archives, can you forward it?

Maddy