<div dir="ltr"><div bgcolor="#232729" text="#eeeeec" link="#4a90d9" vlink="#eeeeec" style="word-wrap:break-word;line-break:after-white-space"><div style="width:71ch">On Mon, 2017-12-11 at 11:19 +1030, Joel Stanley wrote:</div><blockquote type="cite"><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>On Mon, Dec 11, 2017 at 11:09 AM, Cyril Bur <<a href="mailto:cyrilbur@gmail.com" target="_blank">cyrilbur@gmail.com</a>> wrote:</pre><blockquote type="cite"><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>The dtb.o files should really only depend on the .dtb files which is</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>already covered by the `%.dtb.o: %.dtb` rule. So remove the specific</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>p9{w,r,z}-fsi.dtb.o rules.</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>.dtb files which need an include file should depend depend on those and</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>their source file. The `%.dtb: %.dts` does not cover this, so</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>p9w-fsi.dtb, p9r-fsi.dtb and p9z-fsi.dtb should have an added</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>dependency currently not listed. Add those targets and dependencies,</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>also mark them as .INTERMEDIATE just like the %.dtb implicitly is.</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>This patch fixes parallel build failure:</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/cyrilb/r/pdbg/review/<wbr>missing autoheader)</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>rm -f stamp-h1</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>touch <a href="http://config.h.in" target="_blank">config.h.in</a></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>cd . && /bin/sh ./config.status config.h</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>config.status: creating config.h</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>config.status: config.h is unchanged</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>make --no-print-directory all-am</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  DTC      fake.dtb</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  M4       p8-fsi.dts</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  M4       p8-i2c.dts</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  M4       p8-host.dts</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  M4       p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  DTC      p9w-fsi.dtb</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Error: p9w-fsi.dts:8.1-6 Label or path fsi0 not found</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>FATAL ERROR: Syntax error parsing input tree</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  DTC      p9z-fsi.dtb</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>make[1]: *** [Makefile:1281: p9w-fsi.dtb] Error 1</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>make[1]: *** Waiting for unfinished jobs....</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>  DTC      p9r-fsi.dtb</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>rm p9w-fsi.dtb p9r-fsi.dtb p8-host.dts p9z-fsi.dtb p8-i2c.dts fake.dtb p8-fsi.dts</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>make: *** [Makefile:442: all] Error 2</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Which can be caused by invoking make with `-j 8` from a fresh checkout.</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Signed-off-by: Cyril Bur <<a href="mailto:cyrilbur@gmail.com" target="_blank">cyrilbur@gmail.com</a>></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>---</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span> Makefile.am | 7 ++++---</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span> 1 file changed, 4 insertions(+), 3 deletions(-)</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>diff --git a/Makefile.am b/Makefile.am</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>index 38a66c4..b817893 100644</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>--- a/Makefile.am</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>+++ b/Makefile.am</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>@@ -66,9 +66,10 @@ DTC_V_0      = @echo "  DTC     " $@;</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span> %.dtsi: %.dtsi.m4</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>        $(M4_V)m4 -I$(dir $<) $< > $@</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>-p9w-fsi.dtb.o: p9w-fsi.dts p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>-p9r-fsi.dtb.o: p9r-fsi.dts p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>-p9z-fsi.dtb.o: p9z-fsi.dts p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>+.INTERMEDIATE: p9w-fsi.dtb p9r-fsi.dtb p9z-fsi.dtb</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>+p9w-fsi.dtb: p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>+p9r-fsi.dtb: p9-fsi.dtsi</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>+p9z-fsi.dtb: p9-fsi.dtsi</pre></blockquote><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Nak. The dtb is built from the dts, so the rule should be  dtb: dts.</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>There's an additional dependency on the dtsi, so we make sure that is</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>listed too.</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre></blockquote><div style="width:71ch"><br></div><div style="width:71ch">The wisdom from SFR is that if a recipie only has dependencies, it simply adds dependency, so the %.dtb rule will add the .dts as <span id="m_-7933161183691182866-x-evo-selection-start-marker"></span><span id="m_-7933161183691182866-x-evo-selection-end-marker"></span>dependency. I'm the first to admit I don't know make nearly well enough to be sure, but I'm also happy to defer to sfr on almost anything.</div><div style="width:71ch"><br></div><div style="width:71ch">Cyril</div><div style="width:71ch"><br></div><blockquote type="cite"><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Think of it like a C file:</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>foo.o: foo.c foo.h</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Please take this patch instead:</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span> <a href="https://lists.ozlabs.org/pipermail/pdbg/2017-December/000000.html" target="_blank">https://lists.ozlabs.org/<wbr>pipermail/pdbg/2017-December/<wbr>000000.html</a></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Cheers,</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Joel</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><blockquote type="cite"><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span> %.dtb: %.dts</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>        $(DTC_V)dtc -q -i$(dir $@) -I dts $< -O dtb > $@</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>--</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>2.15.1</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>--</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span>Pdbg mailing list</pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><a href="mailto:Pdbg@lists.ozlabs.org" target="_blank">Pdbg@lists.ozlabs.org</a></pre><pre><span class="m_-7933161183691182866-x-evo-quoted"><span class="m_-7933161183691182866-x-evo-quote-character">> </span><span class="m_-7933161183691182866-x-evo-quote-character">> </span></span><a href="https://lists.ozlabs.org/listinfo/pdbg" target="_blank">https://lists.ozlabs.org/<wbr>listinfo/pdbg</a></pre></blockquote></blockquote><div class="m_-7933161183691182866-x-evo-signature-wrapper"><span class="m_-7933161183691182866-x-evo-signature" id="m_-7933161183691182866none"></span></div></div></div>