<div dir="ltr"><div dir="ltr"><div><div><div>Stephen,<br><br></div>Thank you for the review. I'll address the comments on the parser patch and submit a v3 within the next 2 weeks. My time to work on this is a bit limited as well.<br></div>For the front-end representation of the dependencies, I want to represent these relations on a series detail view, which doesn't exist yet. Maybe, once the patches for the series detail view are merged, I can to add that as well.<br><br></div><div>Regards,<br></div>Adam<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 31, 2024 at 6:45 PM Stephen Finucane <stephen@that.guru> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 2024-08-29 at 10:54 -0400, Adam Hassick wrote:<br>
> Stephen,<br>
> <br>
> Is there anything I need to do before this patch can be reviewed? It<br>
> has been a while, I just want to make sure that I am not blocking this<br>
> in any way.<br>
<br>
Apologies for the delay on this but my time is limited recently :(<br>
<br>
I think I've reviewed everything. The only comments I had were on the parser<br>
changes. In addition, I don't see any changes for the web UI here. Have you any<br>
plans for exposing it through said interface?<br>
<br>
I'll test this (or, better, try to delegate testing to someone) from a<br>
performance perspective over the weekend but I see the joins there and imagine<br>
things are fine.<br>
<br>
Nice work, again.<br>
<br>
Stephen<br>
<br>
> On Tue, Jul 30, 2024 at 5:04 PM Adam Hassick <<a href="mailto:ahassick@iol.unh.edu" target="_blank">ahassick@iol.unh.edu</a>> wrote:<br>
> > <br>
> > This patch series adds support for series dependencies. A series dependency<br>
> > may be declared by another series when that series alone will not apply,<br>
> > compile, or otherwise function properly without the dependent series.<br>
> > <br>
> > Including the "Depends-on" tag in any patch commit message or in the cover<br>
> > letter blurb will signal Patchwork to add the referenced series as a<br>
> > dependency. The value for this tag may be a message ID of the dependent<br>
> > series cover letter or any patch in the dependent series. Or, alternatively,<br>
> > it may be the web URL of the dependent series or any patch in that series.<br>
> > <br>
> > v2:<br>
> > * Use message IDs instead of object IDs.<br>
> > * Check for invalid dependencies before adding them.<br>
> > <br>
> > Adam Hassick (7):<br>
> > models: Add field for series dependencies<br>
> > api: Add fields to series detail view<br>
> > parser: Parse "Depends-on" tags in emails<br>
> > tests: Add tests for new functionality<br>
> > docs: Increment API version<br>
> > docs: Add generated API schemas<br>
> > release-notes: Add release note<br>
> > <br>
> > docs/api/rest/index.rst | 42 +-<br>
> > docs/api/rest/schemas/v1.3.rst | 4 +-<br>
> > docs/api/rest/schemas/v1.4.rst | 5 +<br>
> > docs/api/schemas/generate-schemas.py | 4 +-<br>
> > docs/api/schemas/latest/patchwork.yaml | 18 +-<br>
> > docs/api/schemas/patchwork.j2 | 18 +<br>
> > docs/api/schemas/v1.4/patchwork.yaml | 3242 +++++++++++++++++<br>
> > docs/usage/overview.rst | 11 +<br>
> > patchwork/api/series.py | 26 +-<br>
> > .../migrations/0047_series_dependencies.py | 23 +<br>
> > patchwork/models.py | 26 +<br>
> > patchwork/parser.py | 90 +-<br>
> > patchwork/tests/api/test_series.py | 33 +-<br>
> > .../tests/series/dependency-base-patch.mbox | 102 +<br>
> > .../series/dependency-multi-2.mbox.template | 110 +<br>
> > .../series/dependency-multi.mbox.template | 109 +<br>
> > .../series/dependency-one-cover.mbox.template | 128 +<br>
> > .../dependency-one-first-patch.mbox.template | 125 +<br>
> > patchwork/tests/test_parser.py | 52 +<br>
> > patchwork/tests/test_series.py | 271 ++<br>
> > patchwork/urls.py | 10 +-<br>
> > ...-series-dependencies-6696458586e795c7.yaml | 18 +<br>
> > 22 files changed, 4435 insertions(+), 32 deletions(-)<br>
> > create mode 100644 docs/api/rest/schemas/v1.4.rst<br>
> > create mode 100644 docs/api/schemas/v1.4/patchwork.yaml<br>
> > create mode 100644 patchwork/migrations/0047_series_dependencies.py<br>
> > create mode 100644 patchwork/tests/series/dependency-base-patch.mbox<br>
> > create mode 100644 patchwork/tests/series/dependency-multi-2.mbox.template<br>
> > create mode 100644 patchwork/tests/series/dependency-multi.mbox.template<br>
> > create mode 100644 patchwork/tests/series/dependency-one-cover.mbox.template<br>
> > create mode 100644 patchwork/tests/series/dependency-one-first-patch.mbox.template<br>
> > create mode 100644 releasenotes/notes/add-series-dependencies-6696458586e795c7.yaml<br>
> > <br>
> > --<br>
> > 2.45.2<br>
> > <br>
<br>
</blockquote></div></div>