<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body>Ugh. I cannot figure out how to properly respond with this stupid phone. Apologies for the wretched format. <div><br></div><div style="font-size:100%;color:#000000"><!-- originalMessage --><div>-------- Original message --------</div><div>From: Stephen Finucane <stephen@that.guru> </div><div>Date: 6/21/17 4:47 PM (GMT-05:00) </div><div>To: Aaron Conole <aconole@bytheb.org> </div><div>Cc: patchwork@lists.ozlabs.org </div><div>Subject: Re: [PATCH RFC] events-api: allow filtering by date </div><div><br></div></div>On Wed, 2017-06-21 at 21:08 +0100, Stephen Finucane wrote:<br>> On Thu, 2017-06-15 at 09:57 -0400, Aaron Conole wrote:<br>> > Stephen Finucane <stephen@that.guru> writes:<br>> > <br>> > > On Wed, 2017-06-14 at 14:16 -0400, Aaron Conole wrote:<br>> > > > Aaron Conole <aconole@bytheb.org> writes:<br>> > > > <br>> > > > > This commit allows users of the REST API to query for events based on<br>> > > > > the date field. This will allow utility writers to select a smaller<br>> > > > > subset of events when polling.<br>> > > > > <br>> > > > > Signed-off-by: Aaron Conole <aconole@bytheb.org><br>> > > <br>> > > I think I missed this initially because I'd intended to use cursor-based<br>> > > pagination [1] for '/events'. Cursor-based pagination would be beneficial<br>> > > in so<br>> > > far as it allows us to grab a pseudo-permalink to page of events, which<br>> > > isn't<br>> > > possible with page number-based pagination because the page numbers can<br>> > > change<br>> > > way to darn quick. However, it does make '/events' unique in how it does<br>> > > pagination. I can go either way with this, and can submit an RFC for this<br>> > > this<br>> > > evening, if it would help to compare the two.<br>> > <br>> > Sure; I'm fairly inexperienced with web development, so I don't<br>> > understand the nuance between the two approaches.<br>> <br>> Sorry for the delay. I've just submitted that RFC now.<br>> <br>> To compare the two, I'd suggest you take a look at the below:<br>> <br>> https://www.sitepoint.com/paginating-real-time-data-cursor-based-pagination<br>> /<br>> <br>> The gist is that the high volume of events makes it likely that stuff will<br>> get<br>> lost between pages. This really makes sense for '/events' and it might even<br>> make sense for '/patches' and '/series' (as they're also sorted in<br>> chronological order by default), though I doubt we'll change those now.<br><br>...then again, we could accomplish the same thing with the 'until' filter. So<br>long as someone specifies this, we shouldn't see anything getting entered in<br>between the pages.<br><br>I think we can ignore my RFC and merge this, if you agree?<br><br><br>Stephen<br><div><br></div><div><br></div><div>-------------</div><div><br></div><div>Sounds good to me. Sorry for the late reply. I am on vacation and have limited email access. </div></body></html>