Make Acked/Reviewd/Tested-by tags visible

Janne Grunau janne-ml at jannau.net
Wed May 7 20:02:46 EST 2014


Hi,

On 2014-05-07 16:42:51 +0800, Jeremy Kerr wrote:
> 
> > We would like to suggest that the web GUI and the pwclient CLI both
> > display such tags besides each patch, a bit like (hypotetical output of
> > pwclient):
> 
> OK, I have some progress on this one; but wanted to make sure what I'm
> doing is in the direction that'd be generally useful for you.
> 
> How's this look?
> 
>   http://ozlabs.org/~jk/tmp/patchwork-ART.png
> 
> - there are title attributes on the column header, so you get a tooltip
> saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The
> actual numbers have specific tooltips too (eg, "2 Acked-by").
> 
> Also, are you wanting to filter by the presence of these tags? Just
> non-zero? How about sorting?
> 
> Anyone have objections to adding a small column to the default patch
> lists? Does anyone want to *not* have this information present?

We (Libav - https://patches.libav.org) don't use "Acked-by / Reviewed-by / 
Tested-by" tag lines. I would prefer not having the the column in our
default patch list. I don't care about the defaults but simple way to 
disable it would be nice.

Janne


More information about the Patchwork mailing list