<html><body><p><font size="2">Not our top priority, but it is in flight. I would hope end of the month we'll be done.</font><br><font size="2"><br>--<br>Dan Crowell<br>Senior Software Engineer - Power Systems Enablement Firmware<br>IBM Rochester: t/l 553-2987<br>dcrowell@us.ibm.com</font><br><br><img width="16" height="16" src="cid:1__=09BB0E63DFC11ECF8f9e8a93df938690918c09B@" border="0" alt="Inactive hide details for Artem Senichev ---01/15/2020 01:39:04 AM---On Tue, Jan 14, 2020 at 10:51:35AM -0600, Daniel M Crowell"><font size="2" color="#424282">Artem Senichev ---01/15/2020 01:39:04 AM---On Tue, Jan 14, 2020 at 10:51:35AM -0600, Daniel M Crowell wrote: ></font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Artem Senichev <artemsen@gmail.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Daniel M Crowell <dcrowell@us.ibm.com></font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">oohall@gmail.com, openpower-firmware@lists.ozlabs.org</font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">01/15/2020 01:39 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">[EXTERNAL] Re: [OpenPower-Firmware] NVDIMM support</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt><font size="2">On Tue, Jan 14, 2020 at 10:51:35AM -0600, Daniel M Crowell wrote:<br>> <br>> > I can't find corresponded code in Hostboot, the hdatMsAreaAddrRange_t<br>> structure from HB<br>> The Hostboot side of these changes is still under development.<br><br>If it's not a secret, when do you plan to publish these changes?<br><br>-- <br>Regards,<br>Artem Senichev<br>Software Engineer, YADRO.<br><br>> <br>> --<br>> Dan Crowell<br>> Senior Software Engineer - Power Systems Enablement Firmware<br>> IBM Rochester: t/l 553-2987<br>> dcrowell@us.ibm.com<br>> <br>> <br>> <br>> From: Artem Senichev <artemsen@gmail.com><br>> To: oohall@gmail.com<br>> Cc: openpower-firmware@lists.ozlabs.org<br>> Date: 01/14/2020 07:00 AM<br>> Subject: [EXTERNAL] [OpenPower-Firmware] NVDIMM support<br>> Sent by: "OpenPower-Firmware" <openpower-firmware-bounces<br>> +dcrowell=us.ibm.com@lists.ozlabs.org><br>> <br>> Hi Oliver,<br>> <br>> Could you help me with NVDIMM support in OpenPOWER?<br>> <br>> I found your commit to skiboot:<br>> 4822a7ba9 hdata/memory: Add NVDIMM support<br>> <a href="https://github.com/open-power/skiboot/commit/4822a7ba9d33468a15d1c90ee8c0823826d33320">https://github.com/open-power/skiboot/commit/4822a7ba9d33468a15d1c90ee8c0823826d33320</a><br>> <br>> <br>> You added a new field to HDIF_ms_area_address_range structure - phys_attr,<br>> its value defines the type and state of the memory, but I can't find<br>> corresponded code in Hostboot, the hdatMsAreaAddrRange_t structure from HB<br>> doesn't contain these attributes.<br>> <br>> Skiboot (HDIF_ms_area_address_range):<br>> <a href="https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L31">https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L31</a><br>> <br>> Hostboot (hdatMsAreaAddrRange_t):<br>> <a href="https://github.com/open-power/hostboot/blob/f70454687133f8a8b493f44d981ea1673e4ec437/src/usr/hdat/hdatmsarea.H#L132">https://github.com/open-power/hostboot/blob/f70454687133f8a8b493f44d981ea1673e4ec437/src/usr/hdat/hdatmsarea.H#L132</a><br>> <br>> <br>> How are these attributes populated?<br>> <br>> P.S. Also, I suppose there is a typo in Skiboot's code:<br>> <a href="https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L588">https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L588</a><br>> <br>> IMHO, there should be a 'greater' condition, not 'greater or equal'.<br>> The current implementation has equal values of `arr->eactsz` and `offset`<br>> (36 bytes), so reading uint32_t from offset 36 looks strange.<br>> <br>> --<br>> Regards,<br>> Artem Senichev<br>> Software Engineer, YADRO.<br><br></font></tt><br><br><BR>
</body></html>