<div dir="ltr">Hi Krzysztof,<br><br>Thanks for your comments<br><br>On Sun, 19 Oct 2025 at 13:35, Krzysztof Kozlowski <<a href="mailto:krzk@kernel.org">krzk@kernel.org</a>> wrote:<br>><br>> On 25/09/2025 22:06, Tomer Maimon wrote:<br>> > Fix the warning in the gcr and timer nodes, and modify nodes order by<br>><br>> What warning?<br>This warning that I got from Andrew mail<br>[I] 0 andrew@heihei ~/s/k/l/o/build.arm64.default ((00e2ab2e))> make CHECK_DTBS=y nuvoton/nuvoton-npcm845-evb.dtb<br>  SCHEMA  Documentation/devicetree/bindings/processed-schema.json<br>  DTC [C] arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb<br>/home/andrew/src/<a href="http://kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb">kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb</a>: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property<br>        from schema $id: <a href="http://devicetree.org/schemas/memory.yaml#">http://devicetree.org/schemas/memory.yaml#</a><br><b>/home/andrew/src/<a href="http://kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb">kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb</a>: system-controller@f0800000 (nuvoton,npcm845-gcr): compatible: ['nuvoton,npcm845-gcr', 'syscon'] is too short<br>        from schema $id: <a href="http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-gcr.yaml#">http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-gcr.yaml#</a></b><br>><br>> > ascending unit address.<br>><br>> Why are you combining multiple issues into one commit. No. Read<br>> submitting patches how to organize your work.<br>><br>> ><br>> > Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com">tmaimon77@gmail.com</a>><br>> > ---<br>> >  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 35 +++++++++----------<br>> >  1 file changed, 17 insertions(+), 18 deletions(-)<br>> ><br>> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi<br>> > index 24133528b8e9..a43514f624c0 100644<br>> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi<br>> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi<br>> > @@ -18,7 +18,7 @@ soc {<br>> >               ranges;<br>> ><br>> >               gcr: system-controller@f0800000 {<br>> > -                     compatible = "nuvoton,npcm845-gcr", "syscon";<br>> > +                     compatible = "nuvoton,npcm845-gcr", "syscon", "simple-mfd";<br>><br>> This makes no sense. No children here.<br>><br>> >                       reg = <0x0 0xf0800000 0x0 0x1000>;<br>> >               };<br>> ><br>> Best regards,<br>> Krzysztof<div><br></div><div>Best regards,</div><div><br></div><div>Tomer</div></div>