<div dir="ltr"><div dir="ltr"><p class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><span style="font-size:10pt;color:black"><font face="georgia, serif">Dear Patrick Williams and Ed Tanous ,</font></span></p>
<p class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><font face="georgia, serif"> </font></p>
<p class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><span style="font-size:10pt;color:black"><font face="georgia, serif">I hope this message finds you well. I wanted to bring to your
attention some observations regarding the use of Redfish in various
repositories in upstream.</font></span></p>
<p class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><span style="font-size:10pt;color:black"><font face="georgia, serif"> </font></span></p>
<ol style="margin-top:0in;margin-bottom:0in" start="1" type="1">
<li class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><font face="georgia, serif"><span style="font-size:10pt;color:black">After going through couple of repositories,
I discovered that many upstream repositories are already incorporating
Redfish. This is achieved either through journald or by directly calling
the phosphor-logging API to log Redfish-specific metadata. The details of
this implementation can be found here</span>: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgrok.openbmc.org%2Fsearch%3Ffull%3DREDFISH_MESSAGE_ID%26defs%3D%26refs%3D%26path%3D%26hist%3D%26type%3D%26xrd%3D%26nn%3D1%26searchall%3Dtrue&data=05%7C01%7Ccharkude%40nvidia.com%7Ca864c52919e844382cc008dbf5680a7b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638373599440698496%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EjE4DlGunhXXsyQYjeU8%2BVqZRzAGkZRr65MDz2pnNTA%3D&reserved=0" style="color:rgb(5,99,193)">link to the implementation</a>. <span style="font-size:10pt;color:black">Additionally, this approach is documented
in upstream design, available at</span> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdocs%2Fblob%2Fmaster%2Farchitecture%2Fredfish-logging-in-bmcweb.md&data=05%7C01%7Ccharkude%40nvidia.com%7Ca864c52919e844382cc008dbf5680a7b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638373599440698496%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UtZcUrUm9lC3JSg8b3LLsYWY9BBmbKeHzLn3J%2BXtR0Q%3D&reserved=0" style="color:rgb(5,99,193)">link to design documentation</a>.</font></li><li class="gmail-xmsonormal" style="margin:0in;font-size:11pt"><font face="georgia, serif"><span style="font-size:7pt;color:black"> </span><span style="font-size:10pt;color:black">As we observe these repositories, it has become apparent that they possess limited knowledge of Redfish, focusing primarily on essential elements like REDFISH_MESSAGE_ID and REDFISH_MESSAGE_ARGS. I would appreciate your insights on whether this approach is considered an anti-pattern or if there are potential drawbacks associated with this minimalistic understanding of Redfish.</span></font></li></ol>
<ol style="margin-top:0in;margin-bottom:0in" start="3" type="1">
<li class="gmail-xmsolistparagraph" style="margin:0in;font-size:11pt"><span style="font-size:10pt;color:black"><font face="georgia, serif">Currently, our
solution is similar; the key distinction lies in our utilization of D-Bus
instead of the journal to log Redfish-specific data.</font></span></li><li class="gmail-xmsolistparagraph" style="margin:0in;font-size:11pt"><span style="font-size:10pt;color:black"><font face="georgia, serif">Furthermore, we are planning to abstract metadata such as message registry, message arguments and the origin of conditions. This will involve creating a new API that is based on generic (non-Redfish specific) concepts, within Phosphor Logging dedicated to generating logs with Redfish-specific data on the D-Bus. I previously discussed this proposal in more detail in my email from November 2023, which you can find <a href="https://lists.ozlabs.org/pipermail/openbmc/2023-November/034470.html" style="color:rgb(5,99,193)">here</a>.</font></span></li></ol><pre style="margin:0in 0in 0.0001pt 0.25in;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;font-size:10pt"><span style="color:black;font-size:10pt"><font face="georgia, serif"><br></font></span></pre><pre style="margin:0in 0in 0.0001pt 0.25in;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;font-size:10pt"><span style="color:black;font-size:10pt"><font face="georgia, serif">Your insights and feedback on this proposal would be greatly appreciated.</font></span><font face="Courier New"><br></font></pre><pre style="background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;margin:0in 0in 0.0001pt;font-size:10pt;font-family:"Courier New""><span style="color:black"><br></span></pre><pre style="background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;margin:0in 0in 0.0001pt;font-size:10pt"><span style="color:black"><font face="georgia, serif">Best Regards</font></span></pre><pre style="background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;margin:0in 0in 0.0001pt;font-size:10pt"><span style="color:black"><font face="georgia, serif">Chandramohan</font></span></pre><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 1, 2023 at 11:54 PM Patrick Williams <<a href="mailto:patrick@stwcx.xyz">patrick@stwcx.xyz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Nov 29, 2023 at 11:33:30PM +0530, Chandramohan wrote:<br>
> H All,<br>
> <br>
> I wanted to discuss various design approaches for, sending RF events from<br>
> various OpenBMC services for resource create/delete/modify cases (but not<br>
> limited to this),<br>
> Please find the details below:<br>
<br>
I'm not fully grasping what you're trying to solve. Do you have more<br>
details on what your use-case is?<br>
<br>
Generally we _don't_ want all the repositories to know "Redfish". If<br>
what you're proposing is some special Redfish-oriented handling in every<br>
repository, I don't think this will fly.<br>
<br>
For Redfish Events, I suspect someone would need to start a dbus monitor<br>
in BMC web to observe interesting changes and to turn them into Redfish<br>
Events inside bmcweb itself.<br>
<br>
-- <br>
Patrick Williams<br>
</blockquote></div></div>