<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 6/30/23 02:04, Rohit Pai wrote:<br>
</div>
<blockquote type="cite" cite="mid:LV2PR12MB6014B1512E2965258DBB52B8CD2AA@LV2PR12MB6014.namprd12.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}@font-face
{font-family:"Century Gothic";
panose-1:2 11 5 2 2 2 2 2 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hello Johnathan, <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks for your reply. <o:p></o:p></p>
<p class="MsoNormal">>> We're proposing adding a
"ShortName" entry to the JSON configuration file read by
Entity Manager.<o:p></o:p></p>
<p class="MsoNormal">Could you please add some more detail here,
how this would be consumed by ipmid ?
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The sensors can be created by an
application, and we were looking to do modification in one
place where this conversion can happen.
<o:p></o:p></p>
<p class="MsoNormal">Also, as per your proposal we need to know
all possible names of the sensor per platform and configure it
right ? We wanted to propose some auto generation algorithms
where it can take up any new sensors which can get added or
discovered. I agree with you on the point that auto generation
algorithms can produce mangled/duplicate names.
</p>
</div>
</blockquote>
<p>The current plan:</p>
<p>Modify phosphor-dbus-interfaces Sensor/Value.interface.yaml to
include a "ShortName" string entry.<br>
</p>
<p>Modify EntityManager JSON input files to include a "ShortName"
field. The "ShortName", in my current thought process, is
optional. The intent is to use "Name" directly if it is already
short enough to meet IPMI requirements.<br>
<br>
Modify dbus-sensor daemons to properly generate short names based
upon the "ShortName" string provided via D-Bus. The ShortName may
need adjustment if the incoming string has fields that require
regex modification. Once the final ShortName is computed it is
stored as part of the 'struct Sensor' upon which most of the
dbus-sensors are derived.<br>
</p>
<p>Modify phosphor-host-ipmid D-Bus SDR generation to use either
"Name" or "ShortName". This will replace the code that generates
the name from the D-Bus path string currently in use. The
dbus-sensors code returns Value.interface entries with the "Name"
or the "ShortName" fully formed. If the D-Bus record has a
"ShortName" entry, use it directly. Otherwise use the "Name" entry
directly.</p>
<p>The goal of following this model is to provide each OpenBMC
vendor to control how sensor names are emitted. Another goal is to
avoid receiving a series of defect reports issued by QA stating
the name of IPMI sensors are suddenly significantly different that
they were in prior releases of OpenBMC. The proposal here
mitigates this second issue.</p>
<p>I am currently working on a project to do away with some portions
of intel-ipmi-oem and migrating to phosphor-host-ipmid. I'm not
certain I can continue the project if a significant change in how
sensors are named is implemented.<br>
<br>
<snip><br>
</p>
-- <br>
<div class="moz-signature">
<font color="#1F497D"><font face="Century Gothic">Johnathan Mantey<br>
<small>Senior Software Engineer</small><br>
<big><font color="#555555"><small><b>azad te</b><b>chnology
partners</b></small><br>
<small><font color="#1F497D"><small>Contributing to
Technology Innovation since 1992</small></font><small><br>
<font color="#1F497D">Phone: (503) 712-6764<br>
Email: <a href="mailto:johnathanx.mantey@intel.com" class="moz-txt-link-freetext">johnathanx.mantey@intel.com</a></font></small><br>
<br>
</small></font></big></font></font> </div>
</body>
</html>