<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"\7D14\6587\5B57 \5B57\5143";
margin:0cm;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.a
{mso-style-name:"\7D14\6587\5B57 \5B57\5143";
mso-style-priority:99;
mso-style-link:\7D14\6587\5B57;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="#0563C1" vlink="#954F72" style="word-wrap:break-word;text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">Hi Andrew, <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Thanks for the reminder, i write the review in red letters.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<br>
From: Andrew Jeffery <a href="mailto:andrew@aj.id.au">andrew@aj.id.au</a> <br>
Sent: Monday, January 23, 2023 10:01 AM<br>
To: Ryan Sie <a href="mailto:lesly895@gmail.com">lesly895@gmail.com</a>; <a href="mailto:openbmc@lists.ozlabs.org">
openbmc@lists.ozlabs.org</a><br>
Cc: Ryan Sie - TW (HW 1) <a href="mailto:RyanS@supermicro.com.tw">RyanS@supermicro.com.tw</a><br>
Subject: Re: [PATCH] Add Supermicro X13DEM BMC machine<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">[CAUTION: External Mail]<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Hi Ryan,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Thanks for the patch. Please make sure to Cc the upstream lists:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">* <a href="mailto:linux-aspeed@lists.ozlabs.org">
<span style="color:windowtext;text-decoration:none">linux-aspeed@lists.ozlabs.org</span></a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">* <a href="mailto:devicetree@vger.kernel.org">
<span style="color:windowtext;text-decoration:none">devicetree@vger.kernel.org</span></a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">and any other people or lists that are found by running scripts/get_maintainer.pl.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Also, please run your patch through scripts/checkpatch.pl<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">I have a few other comments and queries:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">On Wed, 28 Dec 2022, at 16:52, Ryan Sie wrote:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> Signed-off-by: Ryan Sie <<a href="mailto:ryans@supermicro.com.tw"><span style="color:windowtext;text-decoration:none">ryans@supermicro.com.tw</span></a>><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> ---<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> arch/arm/boot/dts/Makefile | 1 +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> .../boot/dts/aspeed-bmc-supermicro-x13dem.dts | 476
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> ++++++++++++++++++<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> 2 files changed, 477 insertions(+)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> create mode 100644 arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> index 2ee9c043218b..3b89006fa008 100644<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> --- a/arch/arm/boot/dts/Makefile<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +++ b/arch/arm/boot/dts/Makefile<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> @@ -1623,6 +1623,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-quanta-q71l.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-quanta-s6q.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-supermicro-x11spi.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + aspeed-bmc-supermicro-x13dem.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-inventec-transformers.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-tyan-s7106.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> aspeed-bmc-tyan-s8036.dtb \<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> diff --git a/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> new file mode 100644<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> index 000000000000..b94783a52999<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> --- /dev/null<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +++ b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> @@ -0,0 +1,476 @@<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +/dts-v1/;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#include "aspeed-g6.dtsi"<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<dt-bindings/i2c/i2c.h><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +/ {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + model = "AST2600 BMC";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "aspeed,ast2600";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + chosen {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + stdout-path = &uart5;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + bootargs = "console=ttyS4,115200 earlyprintk";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + memory@80000000 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + device_type = "memory";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x80000000 0x40000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reserved-memory {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + ranges;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + gfx_memory: framebuffer {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + size = <0x01000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + alignment = <0x01000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "shared-dma-pool";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reusable;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + video_engine_memory: jpegbuffer {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + size = <0x02000000>; /* 32M */<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + alignment = <0x01000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "shared-dma-pool";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reusable;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + ssp_memory: ssp_memory {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + size = <0x00200000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + alignment = <0x00100000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + compatible = "shared-dma-pool";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + no-map;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">How is this reserved memory used?<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">Supermicro internal use, i will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + leds {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "gpio-leds";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + powerfail {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + default-state = "off";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + gpios = <&gpio0 ASPEED_GPIO(G, 5) GPIO_ACTIVE_LOW>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + iio-hwmon {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "iio-hwmon";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#if 0<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + aliases {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c18 = &imux18;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c19 = &imux19;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c20 = &imux20;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c21 = &imux21;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c22 = &imux22;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + mmc0 = &emmc;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#else<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + aliases {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + mmc0 = &emmc;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#endif<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Please remove the ifdefery.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&emmc_controller {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">> + timing-phase = <0x700FF>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">This is not a valid property. Instead you need to use the clk-phase* properties that upstream provides:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><a href="https://urldefense.com/v3/__https:/git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v6.2-rc5*n348__;Iw!!ORmjBF0Gq6jo!Ycod3yQsReZptIU0NgDMRyLN3q37O4r90hvpuRQyDxlG5EdTGrcNLCKR51sA_ndx8on6ng4dVgBm16nGTg4$"><span style="color:windowtext;text-decoration:none">https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v6.2-rc5*n348__;Iw!!ORmjBF0Gq6jo!Ycod3yQsReZptIU0NgDMRyLN3q37O4r90hvpuRQyDxlG5EdTGrcNLCKR51sA_ndx8on6ng4dVgBm16nGTg4$</span></a>
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">These require knowing how much phase correction you need for a given bus speed.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove timing-phase property, use default first.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&emmc {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + non-removable;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + max-frequency = <100000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + sdhci-drive-type = /bits/ 8 <3>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#if 1<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + bus-width = <4>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#else<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + bus-width = <8>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_emmc_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_emmcdat4_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_emmcdat5_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_emmcdat6_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_emmcdat7_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#endif<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Please remove the ifdefery<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//&jtag1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +// status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Remove commented nodes.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&fmc {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + flash@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "bmc";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-max-frequency = <25000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-tx-bus-width = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + m25p,fast-read;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + partitions {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "fixed-partitions";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + u-boot@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x0 0x100000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "u-boot";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + u-boot-env@3f0000 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x3f0000 0x10000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "u-boot-env";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + u-boot-env-redund@7f0000 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x7f0000 0x10000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "u-boot-env-redund";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Do you actually have both SPI-NOR and eMMC storage for the BMC?<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">Yes, nor-flash for uboot, emmc for kernel+filesystem+supermicro features<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&spi1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + flash@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "spi1:0";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-max-frequency = <25000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-bus-width = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + partitions {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "fixed-partitions";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + all-bios@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "all_part_bios";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x000000000 0x02000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&spi2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_spi2_default &pinctrl_spi2cs1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> &pinctrl_spi2cs2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_qspi2_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + flash@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + label = "spi2:0";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-max-frequency = <100000000>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + spi-bus-width = <2>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + m25p,fast-read;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//&peci0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +// status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Delete commented nodes<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&syscon {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + uart-clock-high-speed;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">This isn't a valid property. Please run your devicetree through `make dtbs_check`.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&adc0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">You must also add the pinctrl properties here to ensure your ADC lines aren't accidentally muxed for other purposes.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will modify it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&adc1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Again here.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will modify it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&gpio0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + gpio-line-names =<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*A0-A7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*B0-B7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*C0-C7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*D0-D7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*E0-E7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*F0-F7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*G0-G7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*H0-H7*/ "","NMI_N","PWRBTN_N","RST_N","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*I0-I7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*J0-J7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*K0-K7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*L0-L7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*M0-M7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*N0-N7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*O0-O7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*P0-P7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*Q0-Q7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*R0-R7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*S0-S7*/ "","","","","PWROK_IN","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*T0-T7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*U0-U7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*V0-V7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*W0-W7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*X0-X7*/ "","BIOS_CMP_IN","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*Y0-Y7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*Z0-Z7*/ "","","PWRBTN_IN","","","","","";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&gpio1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&sgpiom0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + gpio-line-names =<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /* SGPIO output lines */<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OA0-OA7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OB0-OB7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OC0-OC7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OD0-OD7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OE0-OE7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OF0-OF7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OG0-OG7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OH0-OH7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OI0-OI7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*OJ0-OJ7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*DUMMY*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*DUMMY*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /* SGPIO input lines */<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IA0-IA7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IB0-IB7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IC0-IC7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*ID0-ID7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IE0-IE7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IF0-IF7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IG0-IG7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IH0-IH7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*II0-II7*/ "","","","","","","","",<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + /*IJ0-IJ7*/ "","","","","","","","";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&kcs3 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + aspeed,lpc-io-reg = <0xCA2>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&kcs4 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + aspeed,lpc-io-reg = <0xCA4>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//&lpc_sio {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +// status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Delete commented nodes.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">I don't think this node is even legitimate. Does this devicetree compile?<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I confirm that it has been compiled<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&lpc_snoop {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + snoop-ports = <0x80>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//&mbox {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +// status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +//};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Delete commented node.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will modify it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_txd1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_rxd1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_nrts1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndtr1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndsr1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ncts1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndcd1_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_nri1_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_txd2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_rxd2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_nrts2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndtr2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndsr2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ncts2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_ndcd2_default<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + &pinctrl_nri2_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart3 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart4 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart5 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&uart_routing {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mdio0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + ethphy0: ethernet-phy@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "ethernet-phy-ieee802.3-c22";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mac0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-mode = "rgmii";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-handle = <ðphy0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_rgmii1_default>; };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mdio1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + ethphy1: ethernet-phy@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "ethernet-phy-ieee802.3-c22";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mac1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_rgmii2_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-mode = "rgmii";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-handle = <ðphy1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mdio2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + ethphy2: ethernet-phy@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "ethernet-phy-ieee802.3-c22";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mac2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-0 = <&pinctrl_rmii3_default>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + use-ncsi;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mdio3 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + ethphy3: ethernet-phy@0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "ethernet-phy-ieee802.3-c22";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&mac3 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + pinctrl-names = "default";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-handle = <ðphy3>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + phy-mode = "rgmii";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&i2c0 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&i2c1 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "disabled";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +};<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +&i2c2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + multi-master;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + status = "okay";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#if 0<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c-switch@71 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + compatible = "nxp,pca9548";<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <0x71>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + i2c-mux-idle-disconnect;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + imux18: i2c@2 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <2>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + imux19: i2c@3 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <3>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + imux20: i2c@4 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <4>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + imux21: i2c@5 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <5>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + imux22: i2c@6 {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #address-cells = <1>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + #size-cells = <0>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + reg = <6>;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> + };<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> +#endif<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Delete the ifdefery<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:red">I will remove it.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">The rest looks okay.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Cheers,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Andrew<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>