<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 21, 2022 at 5:34 PM Devender Rao <<a href="mailto:devenrao@in.ibm.com">devenrao@in.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-6554113464284509247">




<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Hi All,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
I am planning to deprecate/remove some of the dump plugins as some of the commands are no longer valid or have been captured as part of other plugins.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Remove <a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/altfwprintenv" style="margin:0px;background-color:rgb(255,255,255)" target="_blank">altfwprintenv</a> plugin</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(0,0,0);font-family:ui-monospace,SFMono-Regular,"SF Mono",Menlo,Consolas,"Liberation Mono",monospace;font-size:12px;background-color:rgb(255,255,255);display:inline">This plugin caters
 to capturing "Alt-Flash: U-Boot environment variables" and it is applicable to systems that have 2 BMC chips.</span><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/altfwprintenv" id="m_-1317989977178176109LPNoLPOWALinkPreview" target="_blank">https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/altfwprintenv</a><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<div></div>
pushed the following commit<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<a href="https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52943/21" id="m_-1317989977178176109LPlnk118436" target="_blank">https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52943/21</a></div></div></div></blockquote><div>Prefers @adriana's alternative approach in the review instead of removing this <br></div><div>"<span id="gmail-output">I'm ok with it being removed, an alternative would be to leave it but do not print the error message if the file doesn't exist.
The only system that currently supports the alternate environment is witherspoon, don't think this has being used for debug for the CI machines."</span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-6554113464284509247"><div dir="ltr"><div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
<br>
Consolidating network-related plugins, moving the ipaddr, iplink plugins to network plugin</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Removing <a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/ipaddr" id="m_-1317989977178176109LPNoLPOWALinkPreview_1" target="_blank">https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/ipaddr</a><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Removing <a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/iplink" id="m_-1317989977178176109LPNoLPOWALinkPreview_2" target="_blank">https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/iplink</a><br>
adding functionality from above plugins onto network plugin<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<a href="https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52891/22" id="m_-1317989977178176109LPlnk674315" target="_blank">https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52891/22</a><br>
<br></div></div></div></blockquote><div>The design direction we used for plugin is to keep functionality specific to plugins to support user to attach only required plugins to dump types or systems. Consolidating multiple functionalities into single plugin is going to break this fundamental design point, unless there is strong reason for removing these mini type plugins from the dump.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-6554113464284509247"><div dir="ltr"><div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<div></div>
Remove <a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/servicestatus" id="m_-1317989977178176109LPlnkOWALinkPreview_3" target="_blank">https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/servicestatus</a> plugin
 as it</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
is a time-consuming operation and as we already have <a href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/failedservices" id="m_-1317989977178176109LPlnkOWALinkPreview_4" target="_blank">https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/failedservices</a> plugin
 which</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
collects failed services details.<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<a href="https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/53082/13" id="m_-1317989977178176109LPlnk897787" target="_blank">https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/53082/13</a><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br></div></div></div></blockquote><div>I have already  requeted  to change your initial  commit “<a href="https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52468">https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52468</a>” to print masked services , instead of general status.  Looks like  Andrew requested to add this support , please use git revert feature to remove your initial commit instead of pushing new commit to delete the file. Please refer <a href="https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52468/comment/570e2916_90fcaa89/">https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52468/comment/570e2916_90fcaa89/</a> for more details.</div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-6554113464284509247"><div dir="ltr"><div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
If anyone has dependencies in automation scripts or has a need for them or has any concerns, please respond.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
Regards</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Devender<br>
<br>
<div>
<div id="m_-1317989977178176109LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItZGVidWctY29sbGVjdG9yL2Jsb2IvbWFzdGVyL3Rvb2xzL2RyZXBvcnQuZC9wbHVnaW5zLmQvZmFpbGVkc2VydmljZXM." style="width:100%;margin-top:16px;margin-bottom:16px;max-width:800px;min-width:424px">
<table id="m_-1317989977178176109LPContainer143613" role="presentation" style="padding:12px 36px 12px 12px;width:100%;border-width:1px;border-style:solid;border-color:rgb(200,200,200);border-radius:2px">
<tbody>
<tr style="border-spacing:0px" valign="top">
<td>
<div id="m_-1317989977178176109LPImageContainer143613" style="margin-right:12px;height:120px;overflow:hidden;width:240px">
<a id="m_-1317989977178176109LPImageAnchor143613" href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/failedservices" target="_blank"><img id="m_-1317989977178176109LPThumbnailImageId143613" alt="" style="display: block;" src="https://opengraph.githubassets.com/ce6c79c9f23b83b25bc9ee5d88dcaf23230855ba9a59b2ba1ccb8b64bc5c65ea/openbmc/phosphor-debug-collector" width="240" height="120"></a></div>
</td>
<td style="width:100%">
<div id="m_-1317989977178176109LPTitle143613" style="font-size:21px;font-weight:300;margin-right:8px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px">
<a id="m_-1317989977178176109LPUrlAnchor143613" href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/failedservices" style="text-decoration:none" target="_blank">phosphor-debug-collector/failedservices at master
 · openbmc/phosphor-debug-collector</a></div>
<div id="m_-1317989977178176109LPDescription143613" style="font-size:14px;max-height:100px;color:rgb(102,102,102);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px;margin-right:8px;overflow:hidden">
Collects debug data from the BMC for extraction. Contribute to openbmc/phosphor-debug-collector development by creating an account on GitHub.</div>
<div id="m_-1317989977178176109LPMetadata143613" style="font-size:14px;font-weight:400;color:rgb(166,166,166);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif">
<a href="http://github.com" target="_blank">github.com</a></div>
</td>
</tr>
</tbody>
</table>
</div>
</div>
<br>
<div>
<div id="m_-1317989977178176109LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItZGVidWctY29sbGVjdG9yL2Jsb2IvbWFzdGVyL3Rvb2xzL2RyZXBvcnQuZC9wbHVnaW5zLmQvc2VydmljZXN0YXR1cw.." style="width:100%;margin-top:16px;margin-bottom:16px;max-width:800px;min-width:424px">
<table id="m_-1317989977178176109LPContainer920616" role="presentation" style="padding:12px 36px 12px 12px;width:100%;border-width:1px;border-style:solid;border-color:rgb(200,200,200);border-radius:2px">
<tbody>
<tr style="border-spacing:0px" valign="top">
<td>
<div id="m_-1317989977178176109LPImageContainer920616" style="margin-right:12px;height:120px;overflow:hidden;width:240px">
<a id="m_-1317989977178176109LPImageAnchor920616" href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/servicestatus" target="_blank"><img id="m_-1317989977178176109LPThumbnailImageId920616" alt="" style="display: block;" src="https://opengraph.githubassets.com/ce6c79c9f23b83b25bc9ee5d88dcaf23230855ba9a59b2ba1ccb8b64bc5c65ea/openbmc/phosphor-debug-collector" width="240" height="120"></a></div>
</td>
<td style="width:100%">
<div id="m_-1317989977178176109LPTitle920616" style="font-size:21px;font-weight:300;margin-right:8px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px">
<a id="m_-1317989977178176109LPUrlAnchor920616" href="https://github.com/openbmc/phosphor-debug-collector/blob/master/tools/dreport.d/plugins.d/servicestatus" style="text-decoration:none" target="_blank">phosphor-debug-collector/servicestatus at master
 · openbmc/phosphor-debug-collector</a></div>
<div id="m_-1317989977178176109LPDescription920616" style="font-size:14px;max-height:100px;color:rgb(102,102,102);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px;margin-right:8px;overflow:hidden">
Collects debug data from the BMC for extraction. Contribute to openbmc/phosphor-debug-collector development by creating an account on GitHub.</div>
<div id="m_-1317989977178176109LPMetadata920616" style="font-size:14px;font-weight:400;color:rgb(166,166,166);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif">
<a href="http://github.com" target="_blank">github.com</a></div>
</td>
</tr>
</tbody>
</table>
</div>
</div>
<br>
<br>
</div>
<div></div>
<br>
</div>

</div></blockquote></div></div>