<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Sakari,</p>
<p>Thanks for your review.<br>
</p>
<div class="moz-cite-prefix">On 2022/09/23 δΈε 12:56, Sakari Ailus
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d34e9d22-231c-a843-ecc9-71480d68f918@aspeedtech.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<pre style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">Hi Jammy,
Thanks for the update.</pre>
<div class="moz-cite-prefix">On Wed, Sep 21, 2022 at 10:51:09AM
+0800, Jammy Huang wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20220921025112.13150-2-jammy_huang@aspeedtech.com">
<pre class="moz-quote-pre" wrap="">This introduces support for the Aspeed JPEG format, where the new frame
can refer to previous frame to reduce the amount of compressed data.
The concept is similar to I/P frame of video compression. It will
compare the new frame with previous one to decide which macroblock's
data is changed, and only the changed macroblocks will be compressed.
This Aspeed JPEG format is used by the video engine on Aspeed platforms,
which is generally adapted for remote KVM.
Signed-off-by: Jammy Huang <a class="moz-txt-link-rfc2396E" href="mailto:jammy_huang@aspeedtech.com" moz-do-not-send="true"><jammy_huang@aspeedtech.com></a>
---
.../userspace-api/media/v4l/pixfmt-reserved.rst | 17 +++++++++++++++++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
3 files changed, 19 insertions(+)
diff --git a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
index 0ff68cd8cf62..f62bc76d606f 100644
--- a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
+++ b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
@@ -258,6 +258,23 @@ please make a proposal on the linux-media mailing list.
and it is used by various multimedia hardware blocks like GPU, display
controllers, ISP and video accelerators.
It contains four planes for progressive video.
+ * .. _V4L2-PIX-FMT-AJPG:
+
+ - ``V4L2_PIX_FMT_AJPG``
+ - 'AJPG'
+ - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms,
+ which is generally adapted for remote KVM.
+ On each frame compression, I will compare the new frame with previous
+ one to decide which macroblock's data is changed, and only the changed
+ macroblocks will be compressed.
+
+ The implementation is based on AST2600 A3 datasheet, revision 0.9, which
+ is not publicly available. Or you can reference Video stream data format
+ β ASPEED mode compression of SDK_User_Guide which available on
+ AspeedTech-BMC/openbmc/releases.
+
+ Decoder's implementation can be found here,
+ `<a class="moz-txt-link-freetext" href="https://github.com/AspeedTech-BMC/aspeed_codec/" moz-do-not-send="true">https://github.com/AspeedTech-BMC/aspeed_codec/</a> <a class="moz-txt-link-rfc2396E" href="https://github.com/AspeedTech-BMC/aspeed_codec/" moz-do-not-send="true"><https://github.com/AspeedTech-BMC/aspeed_codec/></a>`__</pre>
</blockquote>
<br>
<pre style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">This is better than the previous versions.
Can you still run
$ scripts/checkpatch.pl --strict --max-line-length=80
?</pre>
</blockquote>
<p>I will correct the length to meet the rule.</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:d34e9d22-231c-a843-ecc9-71480d68f918@aspeedtech.com">
<pre style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">
On the decoder --- which values is the user supposed to use for mode_420,
selector and advance_selector parameters? I think this needs to be
documented.</pre>
</blockquote>
<p>I will add following information to aspeed_codec's github, and
provide recommended</p>
<p>values.<br>
</p>
<p>"The following parameters should be provided by the encoded
stream to let decoder</p>
<p> know how to work, because Aspeed codec does not include the
information needed</p>
<p> for decoding in the header. Users can adjust the three
parameters, mode420, selector,</p>
<p> and advance_selector, to achieve the desired quality level while
at the same time</p>
<p>reduce the storage size."</p>
<blockquote type="cite"
cite="mid:d34e9d22-231c-a843-ecc9-71480d68f918@aspeedtech.com">
<blockquote type="cite"
cite="mid:20220921025112.13150-2-jammy_huang@aspeedtech.com">
<pre class="moz-quote-pre" wrap=""> .. raw:: latex
\normalsize
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index a1a1b51ac599..c72bc3410bee 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1497,6 +1497,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
case V4L2_PIX_FMT_MT21C: descr = "Mediatek Compressed Format"; break;
case V4L2_PIX_FMT_QC08C: descr = "QCOM Compressed 8-bit Format"; break;
case V4L2_PIX_FMT_QC10C: descr = "QCOM Compressed 10-bit Format"; break;
+ case V4L2_PIX_FMT_AJPG: descr = "Aspeed JPEG"; break;
default:
if (fmt->description[0])
return;
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 86cae23cc446..870a7e5ef8ca 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -775,6 +775,7 @@ struct v4l2_pix_format {
#define V4L2_PIX_FMT_HI240 v4l2_fourcc('H', 'I', '2', '4') /* BTTV 8-bit dithered RGB */
#define V4L2_PIX_FMT_QC08C v4l2_fourcc('Q', '0', '8', 'C') /* Qualcomm 8-bit compressed */
#define V4L2_PIX_FMT_QC10C v4l2_fourcc('Q', '1', '0', 'C') /* Qualcomm 10-bit compressed */
+#define V4L2_PIX_FMT_AJPG v4l2_fourcc('A', 'J', 'P', 'G') /* Aspeed JPEG */
/* 10bit raw packed, 32 bytes for every 25 pixels, last LSB 6 bits unused */
#define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Kind regards,
Sakari Ailus
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Best Regards
Jammy</pre>
</body>
</html>