<div dir="ltr"><div dir="ltr">Hi Everyone,<br></div><div class="gmail_quote"><div class="gmail_attr"><br>Currently in dcmihandler <a href="https://github.com/openbmc/phosphor-host-ipmid/blob/4cc61e0e99c9014d2e8d8b25ec52b71c3c4e405b/dcmihandler.cpp#L25" target="_blank">object path</a> for <a href="https://github.com/openbmc/phosphor-host-ipmid/blob/4cc61e0e99c9014d2e8d8b25ec52b71c3c4e405b/dcmihandler.cpp#L26" target="_blank">PCAP_INTERFACE</a> is hardcoded to get settings service. It was discussed earlier in this <a href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/46157" target="_blank">review</a> that this needs to be more dynamic. <br><br>Currently I have 2 options to resolve this:<br><br>1. instead of getting a specific <a href="https://github.com/openbmc/phosphor-host-ipmid/blob/4cc61e0e99c9014d2e8d8b25ec52b71c3c4e405b/dcmihandler.cpp#L74" target="_blank">service</a> with a hardcoded path, set/getPcap should call <a href="https://github.com/openbmc/phosphor-host-ipmid/blob/4cc61e0e99c9014d2e8d8b25ec52b71c3c4e405b/libipmid/utils.cpp#L270" target="_blank">getAllDbusObjects</a>. This will give an object tree and we have to iterate through all the objects implementing the powercap interface. I am not sure if this is safe to do so. Need input from the maintainers.<br><br>2. Another option is to add a compile time flag to select a path.<br><br>Please let me know what you think.<br>-<br>Thanks,<br><div><div><div><div><div>Gaurav</div></div></div></div></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><blockquote type="cite"><div dir="ltr">
</div></blockquote></div></blockquote></div></div>