<div dir="ltr">Thanks Matt.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 4, 2022 at 8:06 PM Matt Spinler <<a href="mailto:mspinler@linux.ibm.com">mspinler@linux.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 1/4/2022 1:36 AM, Kumar Thangavel wrote:<br>
> Hi Patrick/Ed, We are already working on this to fix this issue. Since <br>
> that patch was submitted by Bruce, we posted this in the mailing list <br>
> to get his opinion. After fixing this issue, we will submit the patch <br>
> in gerrit. We need help in testing ZjQcmQRYFpfptBannerStart <br>
> ZjQcmQRYFpfptBannerEnd<br>
> Hi Patrick/Ed,<br>
><br>
> We are already working on this to fix this issue. Since that patch was <br>
> submitted by Bruce, we posted this in the mailing list to get his <br>
> opinion.<br>
> After fixing this issue, we will submit the patch in gerrit. We need <br>
> help in testing this fix in IBM platforms.<br>
><br>
<br>
I can help test on an IBM system.<br>
<br>
> Thanks,<br>
> Kumar.<br>
><br>
><br>
><br>
><br>
> On Tue, Jan 4, 2022 at 2:39 AM Patrick Williams <<a href="mailto:patrick@stwcx.xyz" target="_blank">patrick@stwcx.xyz</a>> wrote:<br>
><br>
> Ed,<br>
><br>
> I think there are other commits needing the IIO functionality now.<br>
> There is at least the pending commit for Humidity that we’d like<br>
> to get merged. I think it is better to move forward with a fix<br>
> rather than backwards with a revert at this point.<br>
><br>
> Kumar/Jayashree,<br>
><br>
> Can you dig into this and get to the bottom of it?<br>
><br>
> - Patrick<br>
> Sent from my iPhone<br>
><br>
> > On Jan 3, 2022, at 11:21 AM, Ed Tanous <<a href="mailto:ed@tanous.net" target="_blank">ed@tanous.net</a>> wrote:<br>
> ><br>
> > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell<br>
> > <<a href="mailto:bruce.mitchell@linux.vnet.ibm.com" target="_blank">bruce.mitchell@linux.vnet.ibm.com</a>> wrote:<br>
> >><br>
> >>> On 12/20/2021 10:29, Ed Tanous wrote:<br>
> >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel<br>
> >>> <<a href="mailto:kumarthangavel.hcl@gmail.com" target="_blank">kumarthangavel.hcl@gmail.com</a>> wrote:<br>
> >>>><br>
> >>>> Hi All,<br>
> >>>><br>
> >>>> Gentle Reminder on this.<br>
> >>>><br>
> >>>> Thanks,<br>
> >>>> Kumar.<br>
> >>>><br>
> >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel<br>
> <<a href="mailto:kumarthangavel.hcl@gmail.com" target="_blank">kumarthangavel.hcl@gmail.com</a>> wrote:<br>
> >>>>><br>
> >>>>> Hi All,<br>
> >>>>><br>
> >>>>><br>
> >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon<br>
> Temp Sensor.<br>
> >>>>><br>
> <a href="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab" rel="noreferrer" target="_blank">https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab</a><br>
> >>><br>
> >>> Bruce, this is your patch. Could you take a look at the below and<br>
> >>> provide your input?<br>
> >>><br>
> >>>>><br>
> >>>>><br>
> >>>>> While testing those changes in my platform, I found that<br>
> each sensor in hwmon temp has been creating twice.<br>
> >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP<br>
> sensor is created twice.<br>
> >>>>><br>
> >>>>><br>
> >>>>> /sys/class/hwmon/hwmon2/temp2_input<br>
> >>>>> /sys/class/hwmon/hwmon2/temp1_input<br>
> >>>>><br>
> >>>>><br>
> >>>>> Before your change, hwmon temp sensor will check whether the<br>
> path is already exists or not.<br>
> >>>>> If it exists, it will skip and proceed with next path.<br>
> >>>>><br>
> <a href="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96" rel="noreferrer" target="_blank">https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96</a><br>
> >>>>><br>
> >>>>><br>
> >>>>> Could you please explain why it is creating twice in hwmon<br>
> temp ?<br>
> >>>>><br>
> >>>>><br>
> >>>>> Journalctl log before your changes applied :<br>
> >>>>><br>
> >>>>><br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :<br>
> "/sys/class/hwmon/hwmon2/temp2_input"<br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :<br>
> xyz.openbmc_project.Configuration.TMP421<br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name :<br>
> SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP<br>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :<br>
> "/sys/class/hwmon/hwmon2/temp1_input"<br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> Journalctl log after your changes applied :<br>
> >>>>><br>
> >>>>><br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> "/sys/class/hwmon/hwmon2/temp2_input"<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type<br>
> : xyz.openbmc_project.Configuration.TMP421<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :<br>
> SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP<br>
> >>>>><br>
> >>>>><br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> "/sys/class/hwmon/hwmon2/temp1_input"<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type<br>
> : xyz.openbmc_project.Configuration.TMP421<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :<br>
> SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :<br>
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP<br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> Thanks,<br>
> >>>>><br>
> >>>>> Kumar.<br>
> >><br>
> >> I will give it quick look today. Also today is my last day at IBM.<br>
> >><br>
> ><br>
> > Do you plan on continuing this beyond your tenure at IBM? If<br>
> not, is<br>
> > someone taking this feature over for you? Given it's been a few<br>
> weeks<br>
> > since this regression was reported, and I don't see any fixes in<br>
> > review, I'm leaning toward reverting it on master for the time being<br>
> > until someone puts up a patch to fix the issue.<br>
><br>
<br>
</blockquote></div>