<div dir="ltr">Hi All,<br><div><br></div><div>Gentle Reminder on this.</div><div><br></div><div>Thanks,</div><div>Kumar.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <<a href="mailto:kumarthangavel.hcl@gmail.com">kumarthangavel.hcl@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Hi All,</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br>In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.<br style="box-sizing:border-box"><a aria-label="Link https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab" title="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab" href="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab" rel="noopener noreferrer" style="box-sizing:border-box;background-color:transparent;outline-style:none;color:rgb(98,100,167);text-decoration-line:none" target="_blank">https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab</a></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.<br style="box-sizing:border-box">After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">/sys/class/hwmon/hwmon2/temp2_input<br style="box-sizing:border-box">/sys/class/hwmon/hwmon2/temp1_input</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Before your change, hwmon temp sensor will check whether the path is already exists or not.<br style="box-sizing:border-box">If it exists, it will skip and proceed with next path.<br style="box-sizing:border-box"><a aria-label="Link https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96" title="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abl96" href="https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96" rel="noopener noreferrer" style="box-sizing:border-box;background-color:transparent;outline-style:none;color:rgb(98,100,167);text-decoration-line:none" target="_blank">https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96</a></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Could you please explain why it is creating twice in hwmon temp ?</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Journalctl log before your changes applied :</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"<br style="box-sizing:border-box">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421<br style="box-sizing:border-box">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP<br style="box-sizing:border-box">Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Journalctl log after your changes applied :</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br style="box-sizing:border-box"></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP<br style="box-sizing:border-box">Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit"><br></p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Thanks,</p><p style="box-sizing:border-box;margin:0px;color:rgb(36,36,36);font-family:"Segoe UI",system-ui,"Apple Color Emoji","Segoe UI Emoji",sans-serif;font-size:14px;font-style:inherit;font-weight:inherit">Kumar.</p></div>
</blockquote></div>