<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Alexander,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
We face the same challenges at HPE and spent some time discussing with code maintainers. I must admit that i had the same position than the one you are taking. But while processing some of our patches, upstreaming them can help enhancing the code and maintainability,
by introducing new abstraction layers which are providing interfaces to vendor specific requirements. It is not always the case, but a good example could be found within the iKVM code, which is tightly coupled to Aspeed currently. </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Our situation is even worse as we do have our own BMC asic, we do not use Aspeed. So how to integrate a bunch of hardware specific code into something which is specific to somebody else. We need to re-architecture part of the code. It is a pain, but part of
the game. It would have been better if the code had been thought from the beginning to be more modular or with wider open mind. But in many cases, learning by mistake is also a good way to build something great. It was about the same regarding the x86-power
management where we have GPIOs which are not compatible with upstream. So we had to propose enhancement and modifications.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
With that said, it is going to be a huge effort for hardware vendors, but I think we need to do it even if that is going to be boring and complicated. </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
What worries me is the time required to do that, and avoid breaking the dynamic. I do not recommend forking, this is a massive pain to maintain.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jean-Marie</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> openbmc <openbmc-bounces+jean-marie.verdun=hpe.com@lists.ozlabs.org> on behalf of Alexander Amelkin <a.amelkin@yadro.com><br>
<b>Sent:</b> Wednesday, September 22, 2021 5:02 AM<br>
<b>To:</b> Ed Tanous <edtanous@google.com>; OpenBMC Maillist <openbmc@lists.ozlabs.org><br>
<b>Subject:</b> Re: New test for patches in openbmc/openbmc</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Ed!<br>
<br>
Most patches you listed (at least those for YADRO) are<br>
platform specific and no repository will accept them for<br>
a general audience.<br>
<br>
No vendor, I'm confident, is willing to spend endless time<br>
persuading maintainers to include vendor-specific or<br>
platform-specific patches into their repositories.<br>
<br>
For instance, <br>
meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0002-Add-support-for-boot-initiator-mailbox.patch<br>
is there because our customers demand this feature and we failed<br>
proving to openbmc maintainers that this is a needed feature<br>
and not a "security threat" or something. We honestly tried for months.<br>
<br>
On the other hand, <br>
meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0004-aspeed-add-bmc-position-support.patch<br>
is strictly hardware-specific and is not needed as is for other<br>
vendors or platforms, and we don't have time to make it a<br>
generic solution. If we ever do have that time, we will surely<br>
push the developed generic solution to the appropriate<br>
repository.<br>
<br>
What you propose now will force vendors to move farther away<br>
from upstream and create their own forks of openbmc where<br>
they will not even try to upstream their changes and will just drift<br>
farther and farther away.<br>
<br>
Is that what you really pursue or did I get your idea wrong?<br>
So far it looks to me like a destructive decision.<br>
<br>
WBR, Alexander.<br>
<br>
22.09.2021 01:35, Ed Tanous пишет:<br>
> A few new features have been merged into CI that will now disallow<br>
> .patch files within most meta layers. This is due to a significant<br>
> number of them popping up in both reviews and in the repo itself,<br>
> despite having documented rules to the contrary. The hope here is to<br>
> better codify our rules, and give very quick response to submitters<br>
> about the right procedure so we can encourage getting patches in<br>
> faster, and keep machines buildable against master. As the patches<br>
> state, meta-phosphor is still allowed to contain patch files as an<br>
> escape hatch, if the community decides it's required.<br>
><br>
> The patchsets in question are here:<br>
> <a href="https://gerrit.openbmc-project.xyz/q/repotest">https://gerrit.openbmc-project.xyz/q/repotest</a>
<br>
><br>
> And add some ability for us to make more of these expectations for<br>
> meta layers codified in the future.<br>
><br>
> The script itself is here:<br>
> <a href="https://github.com/openbmc/openbmc/blob/master/meta-phosphor/scripts/run-repotest.sh">https://github.com/openbmc/openbmc/blob/master/meta-phosphor/scripts/run-repotest.sh</a><br>
> and is runnable on any tree prior to submitting to CI. We currently<br>
> have the following patches in meta layers.<br>
><br>
> meta-amd/meta-ethanolx/recipes-x86/chassis/x86-power-control/0001-Amd-power-control-modifications-for-EthanolX.patch<br>
> meta-ampere/meta-common/recipes-devtools/mtd/mtd-utils/0001-flashcp-support-offset-option.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0001-aspeed-scu-Switch-PWM-pin-to-GPIO-input-mode.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0002-aspeed-Disable-internal-PD-resistors-for-GPIOs.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0003-aspeed-support-passing-system-reset-status-to-kernel.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0004-aspeed-add-gpio-support.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0005-aspeed-Enable-SPI-master-mode.patch<br>
> meta-ampere/meta-jade/recipes-bsp/u-boot/u-boot-aspeed/0006-aspeed-support-Mt.Jade-platform-init.patch<br>
> meta-aspeed/recipes-bsp/u-boot/files/default-gcc.patch<br>
> meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0001-bytedance-g220a-Enable-ipmb.patch<br>
> meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0003-misc-aspeed-Add-Aspeed-UART-routing-control-driver.patch<br>
> meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0004-ARM-dts-aspeed-Add-uart-routing-node.patch<br>
> meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0005-ARM-dts-aspeed-Enable-g220a-uart-route.patch<br>
> meta-bytedance/meta-g220a/recipes-phosphor/ipmi/phosphor-node-manager-proxy/0001-Remove-Total_Power-sensor.patch<br>
> meta-facebook/meta-bletchley/recipes-bsp/u-boot/u-boot-aspeed-sdk/0001-u-boot-ast2600-57600-baudrate-for-bletchley.patch<br>
> meta-facebook/meta-tiogapass/recipes-bsp/u-boot/u-boot-aspeed/0001-configs-ast-common-use-57600-baud-rate-to-match-Tiog.patch<br>
> meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed/0001-board-aspeed-Add-Mux-for-yosemitev2.patch<br>
> meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed/0002-spl-host-console-handle.patch<br>
> meta-google/dynamic-layers/nuvoton-layer/recipes-bsp/images/npcm7xx-igps/0001-Set-FIU0_DRD_CFG-and-FIU_Clk_divider-for-gbmc-hoth.patch<br>
> meta-google/recipes-extended/libconfig/files/0001-conf2struct-Use-the-right-perl.patch<br>
> meta-google/recipes-extended/libconfig/files/0001-makefile-Add-missing-LDFLAGS.patch<br>
> meta-google/recipes-phosphor/initrdscripts/obmc-phosphor-initfs/rwfs-clean-dev.patch<br>
> meta-ingrasys/meta-zaius/recipes-bsp/u-boot/u-boot-aspeed/0001-board-aspeed-Add-reset_phy-for-Zaius.patch<br>
> meta-nuvoton/recipes-bsp/images/npcm7xx-igps/0001-Adjust-paths-for-use-with-Bitbake.patch<br>
> meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0001-Add-system-reset-status-support.patch<br>
> meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0002-config-ast-common-set-fieldmode-to-true.patch<br>
> meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0003-aspeed-add-gpio-support.patch<br>
> meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0004-aspeed-add-bmc-position-support.patch<br>
> meta-yadro/meta-nicole/recipes-kernel/linux/linux-aspeed/0001-Add-NCSI-channel-selector.patch<br>
> meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch<br>
> meta-yadro/recipes-phosphor/dbus/phosphor-dbus-interfaces/0001-Add-boot-initiator-mailbox-interface.patch<br>
> meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0001-Add-support-for-persistent-only-settings.patch<br>
> meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0002-Add-support-for-boot-initiator-mailbox.patch<br>
> meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0003-Fix-version-parsing-update-AUX-revision-info.patch<br>
><br>
> If you are a maintainer of these meta layers, please work to get these<br>
> patches submitted to the correct repositories using their prefered<br>
> review (email for linux/u-boot, gerrit for phosphor repos).<br>
><br>
> Thanks,<br>
><br>
> -Ed<br>
</div>
</span></font></div>
</body>
</html>