<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=big5">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Andrei,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I think I have figured out the root cause that's I didn't add the command in the ipmi-whitelist.conf within the intel-ipmi-oem. Thank you all the same.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Chris Chen</div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>寄件者:</b> openbmc <openbmc-bounces+chris.chen3=flex.com@lists.ozlabs.org> 代表 Chris Chen (TPI) <Chris.Chen3@flex.com><br>
<b>寄件日期:</b> 2021年9月7日 下午 05:52<br>
<b>收件者:</b> Andrei Kartashev <a.kartashev@yadro.com>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org><br>
<b>主旨:</b> 回覆: 回覆: [phosphor-host-ipmid] Questions about IPMI (OEM) command development</font>
<div> </div>
</div>
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Andrei,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
One more thing would like to consult you is I have tried to add our own xxx-ipmi-oem, but got the "Insufficient privilege level" feedback after executing an oem command. However, it would be successful in case I removed intel-ipmi-oem. Do you have experience
with this? If yes, may I know how to fix it?<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I currently would like to keep leveraging the intel-ipmi-oem until I integrate the commands I needed into our own xxx-ipmi-oem.<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thank you.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Regards,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Chris Chen</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>寄件者:</b> openbmc <openbmc-bounces+chris.chen3=flex.com@lists.ozlabs.org> 代表 Chris Chen (TPI) <Chris.Chen3@flex.com><br>
<b>寄件日期:</b> 2021年9月7日 上午 08:35<br>
<b>收件者:</b> Andrei Kartashev <a.kartashev@yadro.com>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org><br>
<b>主旨:</b> 回覆: 回覆: [phosphor-host-ipmid] Questions about IPMI (OEM) command development</font>
<div> </div>
</div>
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Anrdrei,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thank you for your helpful comments.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Regards,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Chris Chen </div>
<div>
<div id="x_x_appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>寄件者:</b> Andrei Kartashev <a.kartashev@yadro.com><br>
<b>寄件日期:</b> 2021年9月6日 下午 06:15<br>
<b>收件者:</b> Chris Chen (TPI) <Chris.Chen3@flex.com>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org><br>
<b>主旨:</b> Re: 回覆: [phosphor-host-ipmid] Questions about IPMI (OEM) command development</font>
<div> </div>
</div>
<div class="x_x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_x_PlainText">Hello,<br>
<br>
I don't represent Intel, but have some considerations about this topic:<br>
1) Try to not reuse intel-ipmi-oem. Much better solution would be to<br>
create your own xxx-ipmi-oem package and implement only methods you<br>
really need.<br>
2) Better way would be to implement required logic in phosphor-host-<br>
ipmid and submit changes there. I didn't investigate this yet since we<br>
also pull intel-ipmi-oem to our project, but I believe, it should not<br>
be too difficult. Don't repeat our mistakes ).<br>
3) There is priority argument which you can use to determine handler<br>
call order.<br>
4) Most functions there are specific for Intel servers, so the useless<br>
even is you use Intel CPUs but your own platform.<br>
5) Use "journalctl -t ipmid -o pretty-json" or something like this. But<br>
now it is recommended to use new syntax:<br>
<a href="https://urldefense.com/v3/__https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md__;!!HSntlCg!G61XcVxUr8Hli8HqIlebVYji3tTPXsn33W5oyo-FlU8fbm6Zd66S0H6cseru6Bcw$">https://urldefense.com/v3/__https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md__;!!HSntlCg!G61XcVxUr8Hli8HqIlebVYji3tTPXsn33W5oyo-FlU8fbm6Zd66S0H6cseru6Bcw$</a>
<br>
<br>
<br>
On Mon, 2021-09-06 at 09:40 +0000, Chris Chen (TPI) wrote:<br>
> Hi all,<br>
> <br>
> I guess this mail was got overwhelmed by bunches of emails, so please<br>
> let me resend it and hope someone could help me. Another, I add one<br>
> more question marked #5 below.<br>
> <br>
> Thank you.<br>
> <br>
> Regards,<br>
> Chris Chen<br>
> <br>
> 寄件者: openbmc <openbmc-bounces+chris.chen3=flex.com@lists.ozlabs.org> 代表<br>
> Chris Chen (TPI) <Chris.Chen3@flex.com><br>
> 寄件日期: 2021年9月2日 下午 06:34<br>
> 收件者: openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org><br>
> 主旨: [phosphor-host-ipmid] Questions about IPMI (OEM) command<br>
> development <br>
> Hi all,<br>
> <br>
> I have studied "phosphor-host-ipmid" package for a couple of weeks and<br>
> got understanding that it has implemented some mandatory and optional<br>
> commands already. And I also knew that I'm able to leverage "intel-<br>
> ipmi-oem" package to get more command handlers. But there're some<br>
> questions raised in my mind, I hope someone could give me some<br>
> suggestions.<br>
> 1. What's the normal development procedure in case I want to make<br>
> our own OEM commands? I mean do you guys encourage me to create a new<br>
> "xxx-ipmi-oem" package or to leverage "intel-ipmi-oem" and then add our<br>
> own commands in it?<br>
> 2. I for now added "intel-ipmi-oem" package only for using its<br>
> "<Chassis>:<Set Front Panel Enables>" command because I figured out the<br>
> same command in the "phosphor-host-ipmid" is not able to match the d-<br>
> bus interface in the "x86-power-control". I'm not sure if I will need<br>
> other commands in the "intel-ipmi-oem", but what if I don't need other<br>
> commands, how to remove them? to use the whitelist mechanism?<br>
> 3. Is it okay to add more than 1 xxx-ipmi-ome packages? If yes, how<br>
> to manage the whitelist between these 2 OEM packages?<br>
> 4. Am I able to use "intel-ipmi-oem" on a platform that is using AMD<br>
> CPU?<br>
> 5. How to print the "entry("SENDER=%s", sender.c_str())" parts? I<br>
> mean I for now can print out "Set up ipmi context" string after<br>
> following the instruction listed in<br>
> "<a href=""></a>https://urldefense.com/v3/__https://github.com/openbmc/openbmc/wiki/Debugging-OpenBMC*enabling-application-debug__;Iw!!HSntlCg!G61XcVxUr8Hli8HqIlebVYji3tTPXsn33W5oyo-FlU8fbm6Zd66S0H6csVZtHYM2$
<br>
> ", but I don't see "SENDER=" when I executed "journalctl -t ipmid"<br>
> command.<br>
> 6. 1. log<level::DEBUG>("Set up ipmi<br>
> context",entry("SENDER=%s",sender.c_str()), <br>
> entry("NETFN=0x%X", netFn),entry("LUN=0x%X", lun), <br>
> entry("CMD=0x%X", cmd),entry("CHANNEL=%u", channel), <br>
> entry("USERID=%u", userId), <br>
> entry("SESSIONID=0x%X", sessionId), <br>
> entry("PRIVILEGE=%u",static_cast<uint8_t>(privilege)), <br>
> entry("RQSA=%x", rqSA));<br>
> Thank you.<br>
> <br>
> Regards,<br>
> Chris Chen<br>
> Legal Disclaimer :<br>
> The information contained in this message may be privileged and<br>
> confidential. <br>
> It is intended to be read only by the individual or entity to whom it<br>
> is addressed<br>
> or by their designee. If the reader of this message is not the intended<br>
> recipient,<br>
> is strictly prohibited. If you have received this message in error, <br>
> please immediately notify the sender and delete or destroy any copy of<br>
> this message!<br>
<br>
-- <br>
Best regards,<br>
Andrei Kartashev<br>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>