<div dir="ltr">ah, good catch.<div><br></div><div>I didn't realize that was the case. It looks like it is up to Nuvoton to upstream it.</div><div><br></div><div><a href="https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800">https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800</a><br></div><div><br></div><div>Or maybe I can just make the change for them? Not sure.</div><div><br></div><div>Willy Tu</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 26, 2021 at 6:51 PM Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 26 May 2021 at 15:48, Willy Tu <<a href="mailto:wltu@google.com" target="_blank">wltu@google.com</a>> wrote:<br>
><br>
> ping<br>
><br>
> On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <<a href="mailto:wltu@google.com" target="_blank">wltu@google.com</a>> wrote:<br>
>><br>
>> gsj platform sometimes also see low fan speed issue that can be partly<br>
>> prevented with this fan filter.<br>
<br>
This property is not supported by the kernel, so it will not do<br>
anything. Do you intend to submit driver support?<br>
<br>
>><br>
>> Signed-off-by: Willy Tu <<a href="mailto:wltu@google.com" target="_blank">wltu@google.com</a>><br>
>> ---<br>
>>  arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++<br>
>>  1 file changed, 3 insertions(+)<br>
>><br>
>> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts<br>
>> index 3ff116aaacb3..86facfc08c6e 100644<br>
>> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts<br>
>> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts<br>
>> @@ -408,18 +408,21 @@ fan@0 {<br>
>>                 reg = <0x00>;<br>
>>                 fan-tach-ch = /bits/ 8 <0x00 0x01>;<br>
>>                 cooling-levels = <127 255>;<br>
>> +               fan_filter_en;<br>
>>         };<br>
>><br>
>>         fan@1 {<br>
>>                 reg = <0x01>;<br>
>>                 fan-tach-ch = /bits/ 8 <0x02 0x03>;<br>
>>                 cooling-levels = /bits/ 8 <127 255>;<br>
>> +               fan_filter_en;<br>
>>         };<br>
>><br>
>>         fan@2 {<br>
>>                 reg = <0x02>;<br>
>>                 fan-tach-ch = /bits/ 8 <0x04 0x05>;<br>
>>                 cooling-levels = /bits/ 8 <127 255>;<br>
>> +               fan_filter_en;<br>
>>         };<br>
>>  };<br>
>><br>
>> --<br>
>> 2.31.1.498.g6c1eba8ee3d-goog<br>
>><br>
</blockquote></div>