<div dir="ltr">Hi Tim<div>`/redfish/extended/test_bmc_<span class="gmail-il">dump</span>.robot` suite has usage of older xyz dump path. Can you make use of `redfish/managers/test_bmc_dumps.robot` suite to run the dump automation test? This suite has usage of recent Redfish dump uri implementation i.e. /redfish/v1/Managers/bmc/LogServices/Dump. </div><div><br></div><div>Thanks</div><div>Rahul</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 20, 2021 at 10:00 AM CS20 CHLi30 <<a href="mailto:CHLI30@nuvoton.com">CHLI30@nuvoton.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="ZH-TW">
<div class="gmail-m_996545294996761257WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi All,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">We found that some of "Test Bmc Dump" items are failed when we run test automation.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">After checking log and source code that seems relate to return type of CreateDump() in phosphor-debug-collector<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">is not consistent with OpenBMC-Test-Automation/redfish/extended/test_bmc_dump.robot.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Seems we need to modify test_bmc_dump.robot about return type from "Create User Initiated Dump" keyword<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">from ${dump_id} to object_path according current CreateDump() implementation in phosphor-debug-collector, am I right?<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Summary:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">CreateDump() change return type from uint32_t to object_path from this commit:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://github.com/openbmc/phosphor-debug-collector/commit/6ccb50e133342d20d2758c3efc3f8b429abcbf90#diff-6053a5177ee8dcedec88c55df4de554b5a54497f92b041e1585c6770236773a1" target="_blank">https://github.com/openbmc/phosphor-debug-collector/commit/6ccb50e133342d20d2758c3efc3f8b429abcbf90#diff-6053a5177ee8dcedec88c55df4de554b5a54497f92b041e1585c6770236773a1</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">However, in OpenBMC-Test-Automation/redfish/extended/test_bmc_dump.robot<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Verify User Initiated BMC Dump When Powered Off<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> [Documentation] Create user initiated BMC dump at host off state and<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> ... verify dump entry for it.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> [Tags] Verify_User_Initiated_BMC_Dump_When_Powered_Off<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> Redfish Power Off stack_mode=skip<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> ${dump_id}= Create User Initiated Dump<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"> Check Existence Of BMC Dump File ${dump_id}<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Run keyword "Create User Initiated Dump" still using dump id (uint32_t) to check create bmc dump functionality.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Thus, we got error message from "Check Existence Of BMC Dump File ${dump_id}" as below:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Evaluating expression '/xyz/openbmc_project/dump/bmc/entry/1 == None' failed: SyntaxError: invalid syntax.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Repo steps:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Run test automation: robot -t Verify_User_Initiated_BMC_Dump_When_Powered_Off redfish/extended/test_bmc_dump.robot<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Symptom:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">screenshot from test automation report for you refer it.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><img border="0" width="1040" height="265" id="gmail-m_996545294996761257Picture_x0020_1" src="cid:179a24cd4a15b006a1"></span><span lang="EN-US"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Sincerely,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Tim<u></u><u></u></span></p>
</div>
<hr align="center" width="100%">
<span style="font-size:12pt;line-height:0.7;font-family:Arial;color:rgb(128,128,128)">The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the
addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly
appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
</span>
</div>
</blockquote></div>