<div dir="ltr"><div>Recently one of the d-bus interface got changed in the phosphor-dbug-collector side . Looks like phosphor-dbus-interface version bump is missing here , which causing this build failure.</div><div><br></div><div>Commit details:</div><div><br></div><div><a target="_blank" class="gmail-c-link" href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/37355" rel="noopener noreferrer" style="box-sizing:inherit;text-decoration:underline;font-family:Slack-Lato,appleLogo,sans-serif;font-size:15px;font-style:normal;font-variant-ligatures:common-ligatures;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(248,248,248)">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/37355</a></div><div><a target="_blank" class="gmail-c-link" href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/37802" rel="noopener noreferrer" style="box-sizing:inherit;text-decoration:underline;font-family:Slack-Lato,appleLogo,sans-serif;font-size:15px;font-style:normal;font-variant-ligatures:common-ligatures;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(248,248,248)">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/37802</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 15, 2021 at 2:51 AM Bills, Jason M <<a href="mailto:jason.m.bills@linux.intel.com">jason.m.bills@linux.intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 1/12/2021 9:29 AM, Bills, Jason M wrote:<br>
> Hi All,<br>
> <br>
> Is anyone else seeing build errors in phosphor-debug-collector?<br>
> <br>
> When I build in Yocto, I get this error:<br>
> <br>
> | In file included from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_main.cpp:6: <br>
> <br>
> | <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_bmc.hpp:98:9: <br>
> error: 'sdbusplus::message::object_path <br>
> phosphor::dump::bmc::Manager::createDump(std::map<std::__cxx11::basic_string<char>, <br>
> std::__cxx11::basic_string<char> >)' marked 'override', but does not <br>
> override<br>
> | 98 | createDump(std::map<std::string, std::string> params) <br>
> override;<br>
> | | ^~~~~~~~~~<br>
> | In file included from <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/c++/10.2.0/memory:83, <br>
> <br>
> | from <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/sdbusplus/message.hpp:11, <br>
> <br>
> | from <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/sdbusplus/bus.hpp:7, <br>
> <br>
> | from <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/sdbusplus/server.hpp:3, <br>
> <br>
> | from <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/xyz/openbmc_project/Common/Progress/server.hpp:5, <br>
> <br>
> | from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_entry.hpp:3, <br>
> <br>
> | from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager.hpp:3, <br>
> <br>
> | from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump-extensions.hpp:1, <br>
> <br>
> | from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_main.cpp:3: <br>
> <br>
> | <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/c++/10.2.0/bits/unique_ptr.h: <br>
> In instantiation of 'typename std::_MakeUniq<_Tp>::__single_object <br>
> std::make_unique(_Args&& ...) [with _Tp = phosphor::dump::bmc::Manager; <br>
> _Args = {sdbusplus::bus::bus&, std::unique_ptr<sd_event, <br>
> phosphor::dump::EventDeleter>&, const char (&)[30], const char (&)[36], <br>
> const char (&)[40]}; typename std::_MakeUniq<_Tp>::__single_object = <br>
> std::unique_ptr<phosphor::dump::bmc::Manager>]':<br>
> | <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_main.cpp:68:30: <br>
> required from here<br>
> | <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/c++/10.2.0/bits/unique_ptr.h:962:30: <br>
> error: invalid new-expression of abstract class type <br>
> 'phosphor::dump::bmc::Manager'<br>
> | 962 | { return unique_ptr<_Tp>(new <br>
> _Tp(std::forward<_Args>(__args)...)); }<br>
> | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> | In file included from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_main.cpp:6: <br>
> <br>
> | <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_bmc.hpp:48:7: <br>
> note: because the following virtual functions are pure within <br>
> 'phosphor::dump::bmc::Manager':<br>
> | 48 | class Manager : virtual public CreateIface,<br>
> | | ^~~~~~~<br>
> | In file included from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_bmc.hpp:9, <br>
> <br>
> | from <br>
> ../../../../../../workspace/sources/phosphor-debug-collector/dump_manager_main.cpp:6: <br>
> <br>
> | <br>
> /home/jmbills/openbmc-openbmc/build/tmp/work/arm1176jzs-openbmc-linux-gnueabi/phosphor-debug-collector/1.0+git999-r1/recipe-sysroot/usr/include/xyz/openbmc_project/Dump/Create/server.hpp:55:26: <br>
> note: 'virtual uint32_t <br>
> sdbusplus::xyz::openbmc_project::Dump::server::Create::createDump()'<br>
> | 55 | virtual uint32_t createDump(<br>
> | | ^~~~~~~~~~<br>
> <br>
<br>
It looks like a change was pushed (perhaps <br>
<a href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/39162" rel="noreferrer" target="_blank">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/39162</a>) <br>
that fixes openbmc-build-scripts/run-unit-test-docker.sh. However, I <br>
still see the above override failure when building with Yocto.<br>
<br>
Does anyone else see this error or have any ideas?.<br>
<br>
Thanks,<br>
-Jason<br>
> <br>
> When I build using openbmc-build-scripts/run-unit-test-docker.sh, I get <br>
> this error:<br>
> <br>
> FAILED: <br>
> libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_type_dump.cpp.o <br>
> <br>
> c++ -Ilibpldmresponder/1b80d8d@@pldmresponder@sha -Ilibpldmresponder <br>
> -I../libpldmresponder -Ilibpldm -I../libpldm -I. -I.. -I../oem/ibm <br>
> -I../libpldm/requester -I/usr/local/include -fdiagnostics-color=always <br>
> -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor <br>
> -Wextra -Wpedantic -Werror -std=c++17 -g -Wno-psabi -DOEM_IBM -fPIC -MD <br>
> -MQ <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_type_dump.cpp.o' <br>
> -MF <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_type_dump.cpp.o.d' <br>
> -o <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_type_dump.cpp.o' <br>
> -c ../oem/ibm/libpldmresponder/file_io_type_dump.cpp<br>
> ../oem/ibm/libpldmresponder/file_io_type_dump.cpp: In member function <br>
> 'virtual int pldm::responder::DumpHandler::newFileAvailable(uint64_t)':<br>
> ../oem/ibm/libpldmresponder/file_io_type_dump.cpp:86:60: error: <br>
> 'convertForMessage' is not a member of <br>
> 'sdbusplus::xyz::openbmc_project::Dump::server'<br>
> 86 | sdbusplus::xyz::openbmc_project::Dump::server::convertForMessage(<br>
> | ^~~~~~~~~~~~~~~~~<br>
> ../oem/ibm/libpldmresponder/file_io_type_dump.cpp:86:60: note: suggested <br>
> alternatives:<br>
> In file included from /usr/local/include/sdbusplus/server.hpp:14,<br>
> from ../common/utils.hpp:12,<br>
> from ../oem/ibm/libpldmresponder/file_io.hpp:9,<br>
> from ../oem/ibm/libpldmresponder/file_io_by_type.hpp:3,<br>
> from ../oem/ibm/libpldmresponder/file_io_type_dump.hpp:3,<br>
> from ../oem/ibm/libpldmresponder/file_io_type_dump.cpp:1:<br>
> /usr/local/include/sdbusplus/server/bindings.hpp:21:5: note: <br>
> 'sdbusplus::server::binding::details::convertForMessage'<br>
> 21 | T&& convertForMessage(T&& t)<br>
> | ^~~~~~~~~~~~~~~~~<br>
> In file included from ../common/utils.hpp:13,<br>
> from ../oem/ibm/libpldmresponder/file_io.hpp:9,<br>
> from ../oem/ibm/libpldmresponder/file_io_by_type.hpp:3,<br>
> from ../oem/ibm/libpldmresponder/file_io_type_dump.hpp:3,<br>
> from ../oem/ibm/libpldmresponder/file_io_type_dump.cpp:1:<br>
> /usr/local/include/xyz/openbmc_project/Logging/Entry/server.hpp:268:20: <br>
> note: 'sdbusplus::xyz::openbmc_project::Logging::server::convertForMessage'<br>
> 268 | inline std::string convertForMessage(Entry::Level e)<br>
> | ^~~~~~~~~~~~~~~~~<br>
> ../oem/ibm/libpldmresponder/file_io_type_dump.cpp:87:26: error: <br>
> 'sdbusplus::xyz::openbmc_project::Dump::server::NewDump::DumpType' has <br>
> not been declared<br>
> 87 | NewDump::DumpType::System),<br>
> | ^~~~~~~~<br>
> [23/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_platform_oem_ibm.cpp.o' <br>
> <br>
> [24/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_by_type.cpp.o' <br>
> <br>
> [25/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios_integer_attribute.cpp.o'<br>
> [26/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/pdr.cpp.o'<br>
> [27/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios_string_attribute.cpp.o'<br>
> [28/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io.cpp.o' <br>
> <br>
> [29/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios_attribute.cpp.o'<br>
> [30/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_io_type_pel.cpp.o' <br>
> <br>
> [31/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._oem_ibm_libpldmresponder_file_table.cpp.o' <br>
> <br>
> [32/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios.cpp.o'<br>
> [33/63] Compiling C++ object <br>
> 'softoff/59fd39a@@pldm-softpoweroff@exe/softoff.cpp.o'<br>
> [34/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/pdr_utils.cpp.o'<br>
> [35/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios_enum_attribute.cpp.o'<br>
> [36/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/fru_parser.cpp.o'<br>
> [37/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/event_parser.cpp.o'<br>
> [38/63] Compiling C++ object <br>
> 'utilities/abe2c41@@set-state-effecter@exe/requester_set_state_effecter.cpp.o' <br>
> <br>
> [39/63] Compiling C++ object <br>
> 'utilities/abe2c41@@set-state-effecter-async@exe/requester_set_state_effecter_async.cpp.o' <br>
> <br>
> [40/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._host-bmc_dbus_to_event_handler.cpp.o' <br>
> <br>
> [41/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldm_cmd_helper.cpp.o'<br>
> [42/63] Compiling C++ object 'pldmutils@sha/common_utils.cpp.o'<br>
> [43/63] Compiling C++ object <br>
> 'pldmd@exe/host-bmc_dbus_to_host_effecters.cpp.o'<br>
> [44/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/fru.cpp.o'<br>
> [45/63] Compiling C++ object 'pldmd@exe/pldmd_pldmd.cpp.o'<br>
> [46/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldmtool.cpp.o'<br>
> [47/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/.._host-bmc_host_pdr_handler.cpp.o' <br>
> <br>
> [48/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/platform.cpp.o'<br>
> [49/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/oem_ibm_pldm_oem_ibm.cpp.o'<br>
> [50/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldm_fru_cmd.cpp.o'<br>
> [51/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldm_platform_cmd.cpp.o'<br>
> [52/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldm_base_cmd.cpp.o'<br>
> [53/63] Compiling C++ object <br>
> 'libpldmresponder/1b80d8d@@pldmresponder@sha/bios_config.cpp.o'<br>
> [54/63] Compiling C++ object <br>
> 'pldmtool/ddccc44@@pldmtool@exe/pldm_bios_cmd.cpp.o'<br>
> ninja: build stopped: subcommand failed.<br>
> The command '/bin/sh -c curl -L <br>
> <a href="https://github.com/openbmc/pldm/archive/8fc3edbc65b164eb8c90155b935c91e0e714c461.tar.gz" rel="noreferrer" target="_blank">https://github.com/openbmc/pldm/archive/8fc3edbc65b164eb8c90155b935c91e0e714c461.tar.gz</a> <br>
> | tar -xz && cd pldm-* && meson build --wrap-mode=nodownload <br>
> -Dprefix=/usr/local -Dtests=disabled && ninja -C build && ninja -C build <br>
> install' returned a non-zero code: 1<br>
> ++ cleanup<br>
> ++ local status=1<br>
> ++ [[ -n /tmp/tmp.LkIqDi6uPu ]]<br>
> ++ rm -f /tmp/tmp.LkIqDi6uPu<br>
> ++ trap - EXIT ERR<br>
> ++ exit 1<br>
> <br>
> Anyone have any ideas?<br>
> <br>
> Thanks!<br>
> -Jason<br>
</blockquote></div>