<div dir="ltr"><div dir="ltr">Hi Joel,<div><br></div><div>First tahnks a lot for reviewing the patches.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 11 Jan 2021 at 02:37, Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Tomer,<br>
<br>
On Tue, 5 Jan 2021 at 13:45, Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>> wrote:<br>
><br>
> In this patch set we will like to align with relevant modifications<br>
> in Nuvoton OpenBMC Linux kernel 5.4.<br>
<br>
Thanks for sending the patches. I can merge them into 5.8, however I<br>
have a v5.10 branch that I plan on moving to imminently.<br>
<br>
><br>
> Linux upstream current status:<br>
> 1. npcm7xx clock driver - adding read only<br>
> flag to divider clocks, Will be sent to Linux community.<br>
> 2. Adding NPCM ADC calibration - Will be sent to Linux vanilla,<br>
> but I am not sure it will be approved.<br>
> 3. Add DT restart priority and reset type support - sent to Linux<br>
> community la but havent approved yet.<br>
> 4. persist configuration to the pin control driver - asked by a costumer,<br>
> didnt sent to Linux community.<br>
<br>
Do you plan on sending it?<br></blockquote><div>I need you advise on this one, I pretty sure that the pin cntroller maintainer will refuse to add it </div><div>what do you think?</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> 5. Add HGPIO pin support to NPCM7xx pinctrl driver - will be sent<br>
> to Linux community<br>
> 6. JTAG master driver - will be sent to Linux community once we will<br>
> have BMC folder.<br></blockquote><div>What about the JTAG driver? can you add it please? do I need to move it to soc folder or to leave it in </div><div>misc? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
As you've noted, I recommend you submit them to mainline ASAP to avoid<br>
extra handling of patches in the openbmc tree.<br></blockquote><div>you right, I will do my best... </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Cheers,<br>
<br>
Joel<br>
<br>
><br>
> Changes since version 1:<br>
> - Address comments from Jonathan Neuschäfer: removing trailing whitespace<br>
> in NPCM watchdog documentation.<br>
> - Adding Stanley Chu to NPCM JTAG master driver<br>
><br>
> Tomer Maimon (11):<br>
> clk: npcm7xx: add read only flag to divider clocks<br>
> iio: adc: add calibration support to npcm ADC<br>
> dts: npcm750: add fuse regmap support node<br>
> watchdog: npcm: Add DT restart priority and reset type support<br>
> dt-binding: watchdog: Add DT restart priority and reset type<br>
> pinctrl: npcm7xx: Add HGPIO pin support to NPCM7xx pinctrl driver<br>
> pinctrl: pinconf: add pin persist configuration<br>
> pinctrl: npcm7xx: Add pin persist configuration support<br>
> spi: npcm-pspi: Add full duplex support<br>
> dt-binding: bmc: add NPCM7XX JTAG master documentation<br>
> misc: npcm7xx-jtag-master: add NPCM7xx JTAG master driver<br>
><br>
> .../bindings/bmc/npcm7xx-jtag-master.txt | 38 +<br>
> .../bindings/watchdog/nuvoton,npcm-wdt.txt | 32 +<br>
> arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 6 +<br>
> drivers/clk/clk-npcm7xx.c | 70 +-<br>
> drivers/iio/adc/npcm_adc.c | 191 ++++<br>
> drivers/misc/Kconfig | 6 +<br>
> drivers/misc/Makefile | 1 +<br>
> drivers/misc/npcm7xx-jtag-master.c | 840 ++++++++++++++++++<br>
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 130 ++-<br>
> drivers/pinctrl/pinconf-generic.c | 3 +<br>
> drivers/spi/spi-npcm-pspi.c | 75 +-<br>
> drivers/watchdog/npcm_wdt.c | 121 ++-<br>
> 12 files changed, 1418 insertions(+), 95 deletions(-)<br>
> create mode 100644 Documentation/devicetree/bindings/bmc/npcm7xx-jtag-master.txt<br>
> create mode 100644 drivers/misc/npcm7xx-jtag-master.c<br>
><br>
> --<br>
> 2.22.0<br>
><br></blockquote><div><br></div><div>cheers,</div><div><br></div><div>Tomer </div></div></div>