<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
[Vijay's Comment]
<div>>Can we use extraversion field in manifest file to identify host id. In manifest file, if purpose is >host then we can check extra version and >find out which host it is applicable for.</div>
<div><br>
</div>
<div> [Priyatharshan Response]</div>
<div>We have already brought up the point of using manifest file. As a response, Patrick mentioned as</div>
<div>"I can't imagine that a 16-blade BladeCenter would want to have 16 different files for each slot in the BladeCenter. That doesn't sound like a great user experience".</div>
<div><br>
</div>
<div>[Vijay's Comment]</div>
<div>>Or lese we can add another property in /xyz/openbmc_project/software,</div>
<div>>name as host id and user can set this property after uploading image.</div>
<div>>I don’t agree with creating multiple interfaces for single image</div>
<div>>upgrade. Because image will be deleted after successful activation.</div>
<div><br>
</div>
<div> [Priyatharshan Response]</div>
<div>Your suggestion of adding "host id" property is a good idea, but has few caveates</div>
<div>*. If the image is deleted after programming each host, this brings a sequential nature where bios upgrade time prolongs as many times in multi-host environment (for ex 16-BladeCenter)</div>
<div>*. the image needs to be copied into the target every time and the upgrades needs to be started. The bios.bin file copy causes additional delay in the upgradation</div>
<div>Based on the approach which we porposed,</div>
<div>*. with the single bios image, multiple host can be upgraded using "RequestActivation" in each interface without deleting the bios image</div>
<div>*. as it is multi object approach (one for each host), multiple host could be programmed concurrently</div>
<div>This would save bios upgrade time.</div>
<div><br>
</div>
@Vijay Khemka @patrick@stwcx.xyz @Adriana Kobylak: Kindly share your thoughts on this.<br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Priyatharshan P</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Vijay Khemka <vijaykhemka@fb.com><br>
<b>Sent:</b> 16 October 2020 00:58<br>
<b>To:</b> P. Priyatharshan <PriyatharshanP@hcl.com>; Adriana Kobylak <anoo@linux.ibm.com><br>
<b>Cc:</b> openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org>; anoo@us.ibm.com <anoo@us.ibm.com>; ojayanth@in.ibm.com <ojayanth@in.ibm.com>; gmills@linux.vnet.ibm.com <gmills@linux.vnet.ibm.com>; Velumani T-ERS,HCLTech <velumanit@hcl.com>; ratagupt@linux.vnet.ibm.com
<ratagupt@linux.vnet.ibm.com><br>
<b>Subject:</b> Re: Multi host bios upgrade support in phosphor-bmc-code-mgmt:</font>
<div> </div>
</div>
<style>
<!--
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
p.x_MsoNormal, li.x_MsoNormal, div.x_MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
a:link, span.x_MsoHyperlink
{color:blue;
text-decoration:underline}
span.x_EmailStyle19
{font-family:"Calibri",sans-serif;
color:windowtext}
.x_MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
div.x_WordSection1
{}
-->
</style>
<div lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<p></p>
<p class="x_MsoNormal" style="line-height:12.0pt; background:#FFEB9C"><b><span style="font-size:11.0pt; color:#9C6501"></span></b><span style="font-size:10.0pt; color:red">[CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t
click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]</span></p>
<div>
<div class="x_WordSection1">
<p class="x_MsoNormal">Can we use extraversion field in manifest file to identify host id.</p>
<p class="x_MsoNormal">In manifest file, if purpose is host then we can check extra version</p>
<p class="x_MsoNormal">and find out which host it is applicable for.</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">Or lese we can add another property in <span style="font-size:12.0pt; color:black">
/xyz/openbmc_project/software,</span></p>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">name as host id and user can set this property after uploading image.</span></p>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">I don’t agree with creating multiple interfaces for single image</span></p>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">upgrade. Because image will be deleted after successful activation.</span></p>
<p class="x_MsoNormal"> </p>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="x_MsoNormal"><b><span style="font-size:12.0pt; color:black">From: </span>
</b><span style="font-size:12.0pt; color:black">openbmc <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org> on behalf of "P. Priyatharshan" <PriyatharshanP@hcl.com><br>
<b>Date: </b>Thursday, October 15, 2020 at 10:18 AM<br>
<b>To: </b>Adriana Kobylak <anoo@linux.ibm.com><br>
<b>Cc: </b>"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, "anoo@us.ibm.com" <anoo@us.ibm.com>, "ojayanth@in.ibm.com" <ojayanth@in.ibm.com>, "gmills@linux.vnet.ibm.com" <gmills@linux.vnet.ibm.com>, "Velumani T-ERS, HCLTech" <velumanit@hcl.com>, "ratagupt@linux.vnet.ibm.com"
<ratagupt@linux.vnet.ibm.com><br>
<b>Subject: </b>Re: Multi host bios upgrade support in phosphor-bmc-code-mgmt:</span></p>
</div>
<div>
<p class="x_MsoNormal"> </p>
</div>
<div>
<div>
<div>
<div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">Thanks Adriana for the clarification.
</span></p>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">For host bios update, the images will be copied to BMC(/tmp/images) and will start flashing by making RequestedActivation field "xyz.openbmc_project.Software.Activation.RequestedActivations.Active".
In our case, the device location will be same for all the bios images (BMC /tmp/images).So I think the above design you proposed[id = version+volume ID] may not work effectively for multi host as the id is still going to be same for all the hosts.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">We would like to propose the following approach for your review.Kindly go through the below steps and share your valuable suggestions.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">1.Number of host will be identified from machine layer [OBMC_HOST_INSTANCES]</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">2.Code will be modified to create n number of objects based on number of hosts</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> Ex: Log taken in YosemiteV2 [4 host]</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">root@yosemitev2:~# busctl tree xyz.openbmc_project.Software.BMC.Updater</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">`-/xyz</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/1929c585</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host1</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host1/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host2</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host2/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host3</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host3/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software/host4</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software/host4/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">root@yosemitev2:~# busctl tree xyz.openbmc_project.Software.Version</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">`-/xyz</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host1</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host1/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host2</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host2/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> |-/xyz/openbmc_project/software/host3</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> | `-/xyz/openbmc_project/software/host3/28bd62d9</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software/host4</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> `-/xyz/openbmc_project/software/host4/28bd62d9</span></p>
<p class="x_MsoNormal"> </p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">3.This will create activation interface for each host. For a multi-host system if the RequestedActivation is set to "xyz.openbmc_project.Software.Activation.RequestedActivations.Active", then
different bios service file will be called based the host.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">For single host : biosServiceFile = "obmc-flash-host-bios@" + versionId + ".service";</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">For multi host : biosServiceFile = "obmc-flash-host" + host + "-bios@" + versionId + ".service";
</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">Then it can be used for multi host even if the firmware image we want to install is the same for multiple host targets.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">I have created a WIP patch for the design proposed above.Kindly have a glance and share your comments.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"><a href="https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.openbmc-project.xyz%2Fc%2Fopenbmc%2Fphosphor-bmc-code-mgmt%2F%2B%2F37448&data=04%7C01%7CPriyatharshanP%40hcl.com%7C360bd4e12c3f4766c18708d87140813c%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637383869156208822%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mCKg9YzRECFzIbB0Mp78FH6r5SbSXzWs2HZG4RSHo%2Bs%3D&reserved=0" originalsrc="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/37448" shash="zKq2pSytyb/Uv5Ohh/2L7Uc8rjGtWlWhv3IeHJFajPxjfy/Asf/omiEywrqePmMwAzyu8WQMM3yLWv92DGjPXfvGFHuf/9nYq8KMgC0a8BtVwDGh172rmzFyQf9tQo4Kx8lTh71bv84P9UM4kSIkjIAhDxqwn47LRKXUuEdc/bo=">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/37448</a></span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">Thanks,</span></p>
</div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">Priyatharshan P
</span></p>
</div>
</div>
</div>
</div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
<div class="x_MsoNormal" align="center" style="text-align:center">
<hr size="0" width="100%" align="center">
</div>
<div id="x_divRplyFwdMsg">
<p class="x_MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Adriana Kobylak <anoo@linux.ibm.com><br>
<b>Sent:</b> 06 October 2020 03:11<br>
<b>To:</b> P. Priyatharshan <PriyatharshanP@hcl.com><br>
<b>Cc:</b> Patrick Williams <patrick@stwcx.xyz>; Velumani T-ERS,HCLTech <velumanit@hcl.com>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org>; anoo@us.ibm.com <anoo@us.ibm.com>; ojayanth@in.ibm.com <ojayanth@in.ibm.com>; gmills@linux.vnet.ibm.com <gmills@linux.vnet.ibm.com>;
ratagupt@linux.vnet.ibm.com <ratagupt@linux.vnet.ibm.com><br>
<b>Subject:</b> Re: Multi host bios upgrade support in phosphor-bmc-code-mgmt:</span>
</p>
<div>
<p class="x_MsoNormal"> </p>
</div>
</div>
<div>
<div>
<p class="x_MsoNormal">[CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]<br>
<br>
Hi Priyatharshan,<br>
<br>
> Object : /xyz/openbmc_project/software/[FIRMWARE_VERSION]_[DEVICE]<br>
> where device could be host1, 2, ...,N<br>
> Interface : xyz.openbmc_project.Software.Activation<br>
><br>
> Please confirm if our understanding is correct.<br>
<br>
I meant that to generate the id, which currently uses the version<br>
string, would instead use the version string plus the string for the<br>
name of the device where it's stored in order to generate the hash. For<br>
example, today the code calls "SHA512_Update("version")", where<br>
"version" is for example "2.9.0-dev-663-g2e34bb673". Instead the code<br>
would detect this version is stored let's say in device "mtd1" or<br>
"mmcblk0p1", it'd then append that device string to version, ex:<br>
"2.9.0-dev-663-g2e34bb673-mmcblk0p1" and pass that string to<br>
SHA512_Update(), therefore creating a different hash depending where<br>
that version of bmc code is stored.<br>
<br>
Note that this is for BMC versions only. We discussed that for host<br>
versions, we'd need to modify the code to add a "os-release" file under<br>
/media/ that contained the host version information similar to the BMC's<br>
os-release file. In addition, we'd need to somehow determine that those<br>
files were for host (Bios) versions instead of BMC ones. Perhaps<br>
os-release could have an additional field added to specify the purpose.<br>
<br>
<br>
> Adriana, Any tentative timeline on your commits availability [generate<br>
> the id based on firmware version plus the device or volume ]<br>
<br>
I'd say by early next year at the latest.</p>
</div>
</div>
<p class="x_MsoNormal"><span style="font-size:7.5pt; font-family:"Arial",sans-serif; color:gray">::DISCLAIMER::</span></p>
<div class="x_MsoNormal" align="center" style="text-align:center"><span style="font-size:7.5pt; font-family:"Arial",sans-serif; color:gray">
<hr size="0" width="100%" align="center">
</span></div>
<p class="x_MsoNormal"><span style="font-size:7.5pt; font-family:"Arial",sans-serif; color:gray">The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure
or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the
originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure,
modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before
opening any email and/or attachments, please check them for viruses and other defects.</span></p>
<div class="x_MsoNormal" align="center" style="text-align:center"><span style="font-size:7.5pt; font-family:"Arial",sans-serif; color:gray">
<hr size="0" width="100%" align="center">
</span></div>
</div>
</div>
</div>
</body>
</html>