<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<div class="_3U2q6dcdZCrTrR_42Nxby JWNdg1hee9_Rz6bIGvG1c allowTextSelection">
<div>
<div class="rps_e6fb">
<div dir="ltr">Thanks Adriana for the clarification.
<div><br>
</div>
<div>For host bios update, the images will be copied to BMC(/tmp/images) and will start flashing by making RequestedActivation field "xyz.openbmc_project.Software.Activation.RequestedActivations.Active". In our case, the device location will be same for all
the bios images (BMC /tmp/images).So I think the above design you proposed[id = version+volume ID] may not work effectively for multi host as the id is still going to be same for all the hosts.</div>
<div> </div>
<div>We would like to propose the following approach for your review.Kindly go through the below steps and share your valuable suggestions.</div>
<div><br>
</div>
<div>1.Number of host will be identified from machine layer [OBMC_HOST_INSTANCES]</div>
<div><br>
</div>
<div>2.Code will be modified to create n number of objects based on number of hosts</div>
<div><br>
</div>
<div> Ex: Log taken in YosemiteV2 [4 host]</div>
<div><br>
</div>
<div>root@yosemitev2:~# busctl tree xyz.openbmc_project.Software.BMC.Updater</div>
<div>`-/xyz</div>
<div> `-/xyz/openbmc_project</div>
<div> `-/xyz/openbmc_project/software</div>
<div> |-/xyz/openbmc_project/software/1929c585</div>
<div> |-/xyz/openbmc_project/software/host1</div>
<div> | `-/xyz/openbmc_project/software/host1/28bd62d9</div>
<div> |-/xyz/openbmc_project/software/host2</div>
<div> | `-/xyz/openbmc_project/software/host2/28bd62d9</div>
<div> |-/xyz/openbmc_project/software/host3</div>
<div> | `-/xyz/openbmc_project/software/host3/28bd62d9</div>
<div> `-/xyz/openbmc_project/software/host4</div>
<div> `-/xyz/openbmc_project/software/host4/28bd62d9</div>
<div>root@yosemitev2:~# busctl tree xyz.openbmc_project.Software.Version</div>
<div>`-/xyz</div>
<div> `-/xyz/openbmc_project</div>
<div> `-/xyz/openbmc_project/software</div>
<div> |-/xyz/openbmc_project/software/host1</div>
<div> | `-/xyz/openbmc_project/software/host1/28bd62d9</div>
<div> |-/xyz/openbmc_project/software/host2</div>
<div> | `-/xyz/openbmc_project/software/host2/28bd62d9</div>
<div> |-/xyz/openbmc_project/software/host3</div>
<div> | `-/xyz/openbmc_project/software/host3/28bd62d9</div>
<div> `-/xyz/openbmc_project/software/host4</div>
<div> `-/xyz/openbmc_project/software/host4/28bd62d9</div>
<div><br>
</div>
<div><br>
</div>
<div>3.This will create activation interface for each host. For a multi-host system if the RequestedActivation is set to "xyz.openbmc_project.Software.Activation.RequestedActivations.Active", then different bios service file will be called based the host.</div>
<div><br>
</div>
<div>For single host : biosServiceFile = "obmc-flash-host-bios@" + versionId + ".service";</div>
<div>For multi host : biosServiceFile = "obmc-flash-host" + host + "-bios@" + versionId + ".service";
</div>
<div><br>
</div>
<div><br>
</div>
<div>Then it can be used for multi host even if the firmware image we want to install is the same for multiple host targets.</div>
<div><br>
</div>
<div>I have created a WIP patch for the design proposed above.Kindly have a glance and share your comments.</div>
<div><br>
</div>
<div><a href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/37448" id="LPlnk873192">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/37448</a><br>
</div>
<div><br>
</div>
<div>Thanks,</div>
Priyatharshan P
<div>
<div>
<div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Adriana Kobylak <anoo@linux.ibm.com><br>
<b>Sent:</b> 06 October 2020 03:11<br>
<b>To:</b> P. Priyatharshan <PriyatharshanP@hcl.com><br>
<b>Cc:</b> Patrick Williams <patrick@stwcx.xyz>; Velumani T-ERS,HCLTech <velumanit@hcl.com>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org>; anoo@us.ibm.com <anoo@us.ibm.com>; ojayanth@in.ibm.com <ojayanth@in.ibm.com>; gmills@linux.vnet.ibm.com <gmills@linux.vnet.ibm.com>;
ratagupt@linux.vnet.ibm.com <ratagupt@linux.vnet.ibm.com><br>
<b>Subject:</b> Re: Multi host bios upgrade support in phosphor-bmc-code-mgmt:</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]<br>
<br>
Hi Priyatharshan,<br>
<br>
> Object : /xyz/openbmc_project/software/[FIRMWARE_VERSION]_[DEVICE]<br>
> where device could be host1, 2, ...,N<br>
> Interface : xyz.openbmc_project.Software.Activation<br>
><br>
> Please confirm if our understanding is correct.<br>
<br>
I meant that to generate the id, which currently uses the version<br>
string, would instead use the version string plus the string for the<br>
name of the device where it's stored in order to generate the hash. For<br>
example, today the code calls "SHA512_Update("version")", where<br>
"version" is for example "2.9.0-dev-663-g2e34bb673". Instead the code<br>
would detect this version is stored let's say in device "mtd1" or<br>
"mmcblk0p1", it'd then append that device string to version, ex:<br>
"2.9.0-dev-663-g2e34bb673-mmcblk0p1" and pass that string to<br>
SHA512_Update(), therefore creating a different hash depending where<br>
that version of bmc code is stored.<br>
<br>
Note that this is for BMC versions only. We discussed that for host<br>
versions, we'd need to modify the code to add a "os-release" file under<br>
/media/ that contained the host version information similar to the BMC's<br>
os-release file. In addition, we'd need to somehow determine that those<br>
files were for host (Bios) versions instead of BMC ones. Perhaps<br>
os-release could have an additional field added to specify the purpose.<br>
<br>
<br>
> Adriana, Any tentative timeline on your commits availability [generate<br>
> the id based on firmware version plus the device or volume ]<br>
<br>
I'd say by early next year at the latest.<br>
</div>
</span></font></div>
<font face="Arial" color="Gray" size="1">::DISCLAIMER::<br>
<hr>
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or
incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely
those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent
of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.<br>
<hr>
</font>
</body>
</html>