<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Calibri Light";
panose-1:2 15 3 2 2 2 4 3 2 4;}
@font-face
{font-family:Roboto;
panose-1:2 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"\@MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Bruce,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Let me look into this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">-Vijay<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:black">From: </span></b><span style="color:black">"Bruce Lee (</span><span style="font-family:"MS Gothic";color:black">李昀峻</span><span style="color:black">)" <Bruce_Lee@quantatw.com><br>
<b>Date: </b>Monday, September 21, 2020 at 2:42 AM<br>
<b>To: </b>"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, Vijay Khemka <vijaykhemka@fb.com><br>
<b>Subject: </b>openbmc/phosphor-health-monitor issues, please help check.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif">Hi <span style="color:#212121;background:white">
Vijay,</span></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:#212121;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif">I found one question in
<u><span style="color:#2A66D9;background:white">openbmc/phosphor-health-monitor</span></u></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif">The service healthMon via above functions created<b> has not the org.freedesktop.DBus.ObjectManager on the root</b>,<br>
<span style="color:black;background:white">and this will <u>cause the sensor not be generated correctly</u> via redfish url
<i>/redfish/v1/Chassis/chassis/Sensors/CPU</i>, <i>/redfish/v1/Chassis/chassis/Sensors/Memory</i></span></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif;color:black;background:white">Because redfish will method GetSubTree to collect sensors via
</span><b><span style="font-family:"Calibri Light",sans-serif">org.freedesktop.DBus.ObjectManager</span></b><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif;color:black;background:white">I found a solution for your reference and show at bellow, you can use sdbusplus/server/manager.hpp which provide a function to add ObjectManager on the root.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif;color:black;background:white">Hence, I can get CPU, Memory information correctly via redfish url
<i>/redfish/v1/Chassis/chassis/Sensors/CPU</i>, <i>/redfish/v1/Chassis/chassis/Sensors/Memory</i></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow">#include <sdbusplus/server/manager.hpp></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">class HealthMon</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">{</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> public:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon() = delete;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon(const HealthMon&) = delete;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon& operator=(const HealthMon&) = delete;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon(HealthMon&&) = delete;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon& operator=(HealthMon&&) = delete;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> virtual ~HealthMon() = default;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> /** @brief Constructs HealthMon</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> *</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> * @param[in] bus - Handle to system dbus</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> HealthMon(sdbusplus::bus::bus& bus) : bus(bus)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> {</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> // read json file</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> sensorConfigs = getHealthConfig();</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> createHealthSensors();</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">
<span style="background:yellow;mso-highlight:yellow">add_manager("/");</span></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> }</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> /** @brief Parsing Health config JSON file */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> Json parseConfigFile(std::string configFile);</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> /** @brief reading config for each health sensor component */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> void getConfigData(Json& data, HealthConfig& cfg);</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> /** @brief Map of the object HealthSensor */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> std::unordered_map<std::string, std::shared_ptr<HealthSensor>></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> healthSensors;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> /** @brief Create sensors for health monitoring */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> void createHealthSensors();</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">
<span style="background:yellow;mso-highlight:yellow">void add_manager(const std::string& path)</span></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> {</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> managers_.emplace_back(</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> std::make_unique<sdbusplus::server::manager::manager>(</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> sdbusplus::server::manager::manager(</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> bus, path.c_str())));</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;background:yellow;mso-highlight:yellow"> }</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> private:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> sdbusplus::bus::bus& bus;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> std::vector<HealthConfig> sensorConfigs;</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white"> std::vector<HealthConfig> getHealthConfig();</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">
<span style="background:yellow;mso-highlight:yellow">std::vector<std::unique_ptr<sdbusplus::server::manager::manager>> managers_;</span></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:Roboto;color:black;background:white">};</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:black;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:black;background:white">This pic is the add
</span>org.freedesktop.DBus.ObjectManager on the root for reference.<o:p></o:p></p>
<p class="MsoNormal"><img width="526" height="212" style="width:5.4791in;height:2.2083in" id="圖片_x0020_1" src="cid:image001.jpg@01D69135.E3EBE470"><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:#2A66D9;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><img width="529" height="362" style="width:5.5104in;height:3.7708in" id="圖片_x0020_2" src="cid:image002.jpg@01D69135.E3EBE470"><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:#2A66D9;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal"><strong><span style="font-family:"Calibri Light",sans-serif;color:black;background:white;font-weight:normal">Best Regards</span></strong><span style="font-family:"Calibri Light",sans-serif;color:black;background:white">,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Calibri Light",sans-serif;color:black;background:white">Bruce</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:Roboto;color:#2A66D9;background:white"> </span><o:p></o:p></p>
</div>
</body>
</html>