<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Tom, <br>
</p>
<p>Answers inline.</p>
<p>Regards, <br>
</p>
<p>Richard</p>
<div class="moz-cite-prefix">On 5/15/2020 5:35 PM, TOM JOSEPH wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Hello AppaRao/Richard,</p>
I took a stab at service-config-manager. Got it running on one of
our systems. Thanks for upstreaming it. Few questions i had:<br>
<p>1) Are the Redfish changes yet to be upstreamed?
<a class="moz-txt-link-freetext"
href="https://github.com/openbmc/bmcweb/commit/ec4974dd6a419b7f5556d4dcf4b8b836b5efbbd9"
moz-do-not-send="true">https://github.com/openbmc/bmcweb/commit/ec4974dd6a419b7f5556d4dcf4b8b836b5efbbd9</a>
Why did we not leverage service-config-manager for the Get
method?</p>
</blockquote>
[Richard]: In order to make use of Get method which is applicable to
community, directly used the systemd query implementation, instead
of service-config-manager as it was not used by all.<br>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
2) For the Patch method, do you have code yet to be upstreamed? If
so I will be interested in consuming it. Otherwise I can pick it
up (This is something which I am pursuing <a
class="moz-txt-link-freetext"
href="https://github.com/ibm-openbmc/dev/issues/513"
moz-do-not-send="true">https://github.com/ibm-openbmc/dev/issues/513</a>).
<br>
<br>
</blockquote>
[Richard]: bmcweb code is fully up-streamed. We don't have a code to
do the patch method call. Please go ahead.<br>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
3) Are there plans to upstream the recipe file for
service-config-manager?<br>
<br>
</blockquote>
[Richard]: Yes, need to. It is here <a
href="https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-phosphor/srvcfg-manager/srvcfg-manager_git.bb">https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-phosphor/srvcfg-manager/srvcfg-manager_git.bb</a>
(Don't mind if you can add the same).<br>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
4) The interface exposed by the application looked different from
this
(<a class="moz-txt-link-freetext"
href="https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/Service/Attributes.interface.yaml"
moz-do-not-send="true">https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/Service/Attributes.interface.yaml</a>)<br>
<br>
</blockquote>
[Richard]: Yes, it got updated, as the plan was to allow the
temporary disable of service, and similarly permanent blocking of
service using mask functionality exposed by systemd1. Interface
needs to be updated.<br>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
5) For disabling out of band IPMI, there could be multiple
instances of phosphor-ipmi-net that needs to be disabled/masked.
How do we plan to achieve that? I had couple of options in mind.
Let me know your thoughts.<br>
a) Get all object paths of the service-config-manager which
match phosphor-ipmi-net( phosphor_2dipmi_2dnet) and then disable
each interface.<br>
b) Use the "ListUnits" method on "/org/freedesktop/systemd1"
and get the object paths of phosphor-ipmi-net instances.<span style="display: inline !important; float: none; background-color: rgb(255, 238, 240); color: rgb(3, 47, 98); font-family: SFMono-Regular,Consolas,Liberation Mono,Menlo,monospace; font-size: 12px; font-style: normal; font-variant: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre-wrap; word-spacing: 0px;"></span><br>
<br>
</blockquote>
[Richard]: Internally service-config-manager does ListUnits, and
adds all the phosphor-ipmi-net instances in it's tree. From
application level, querying all the objects exposed by
service-config-manager itself is enough. This is done already in
order to disable RMCP+ in one of our oem IPMI command - <a
href="https://github.com/openbmc/intel-ipmi-oem/blob/master/src/bmccontrolservices.cpp#L141">https://github.com/openbmc/intel-ipmi-oem/blob/master/src/bmccontrolservices.cpp#L141</a>
<blockquote type="cite"
cite="mid:7ff70ad6-8e51-93c3-1175-2bce01e4db77@linux.vnet.ibm.com">
Regards,<br>
Tom<br>
<div class="moz-cite-prefix">On 17-12-2019 08:29, Carol Wang
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CALzeG+83r=v5G_jiCV2M9XErD3fXiMYcti3zknO-YY3_yL59DQ@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">Ok, I got it. Thank you!
Waiting for the change then. :-)
On Mon, Dec 16, 2019 at 9:48 PM Thomaiyar, Richard Marian
<a class="moz-txt-link-rfc2396E" href="mailto:richard.marian.thomaiyar@linux.intel.com" moz-do-not-send="true"><richard.marian.thomaiyar@linux.intel.com></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This came a month back, and i wanted to push the changes in intel repo
to the OpenBMC community repo, due to other priority missed to push the
same.
<a class="moz-txt-link-freetext" href="https://github.com/Intel-BMC/provingground/tree/master/srvcfg-manager" moz-do-not-send="true">https://github.com/Intel-BMC/provingground/tree/master/srvcfg-manager</a>
Will push the document in few day and the changes for the same.
Regards,
Richard
On 12/16/2019 11:38 AM, Carol Wang wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">rface in phosphor-dbus-interface to indicate the status
of net IPMI.
Have a daemon to monitor the status, if the status is changed, then
enable or
disable the net IPMI service and socket.
2. Check the net IPMI socket state by getData()[1] in bmcweb. If the
state is
"running" or "listening", the net IPMI status is true, otherwise, the
status is
false. Then bmcweb can enable or disable the service and socket.
Wondering if anyone has any thoughts on this feature, which way is
better.
If add interface, in which daemon this interface should be implemented?
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>